Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23685007: Have SVGURIReference API deal with Document references, not pointers (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
pdr., dglazkov
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, leviw+renderwatch, Timothy Loh, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Have SVGURIReference API deal with Document references, not pointers Have SVGURIReference API deal with Document references, not pointers as it requires the document to be non-null. This makes it clear to the caller that a non-null Document should be provided. Most caller actually already have a Document reference so this change avoids having to convert them into pointers. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -70 lines) Patch
M Source/core/css/CSSCursorImageValue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.h View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 5 chunks +7 lines, -5 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-02 14:29:40 UTC) #1
dglazkov
lgtm
7 years, 3 months ago (2013-09-02 15:11:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23685007/1
7 years, 3 months ago (2013-09-02 15:15:07 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 16:49:14 UTC) #4
Message was sent while issue was closed. 
Change committed as 157088

Powered by Google App Engine
This is Rietveld 408576698