Source/core/css/resolver/FilterOperationResolver.cpp - Issue 23685007: Have SVGURIReference API deal with Document references, not pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 23685007: Have SVGURIReference API deal with Document references, not pointers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp

index 9f01f0abf6e9123a1f6732916c152e982a23dd0e..14f56ee483e1e16572272535e91964afcab4ee89 100644

--- a/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -405,7 +405,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const Re

KURL url = state.document().completeURL(svgDocumentValue->url());

RefPtr<ReferenceFilterOperation> operation = ReferenceFilterOperation::create(svgDocumentValue->url(), url.fragmentIdentifier(), operationType);

- if (SVGURIReference::isExternalURIReference(svgDocumentValue->url(), &state.document())) {

+ if (SVGURIReference::isExternalURIReference(svgDocumentValue->url(), state.document())) {

if (!svgDocumentValue->loadRequested())

state.elementStyleResources().addPendingSVGDocument(operation.get(), svgDocumentValue);

else if (svgDocumentValue->cachedSVGDocument())