Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/public/v8_platform.h

Issue 2368483002: [gin] Add ConvertableToTraceFormatWrapper (Closed)
Patch Set: Align with v8-platform change. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | gin/v8_platform.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/v8_platform.h
diff --git a/gin/public/v8_platform.h b/gin/public/v8_platform.h
index 2dd32a055570bf2c0e985a9365eb32af27882784..70ee78a41d3054b56b807a4125aeb65ada035859 100644
--- a/gin/public/v8_platform.h
+++ b/gin/public/v8_platform.h
@@ -44,6 +44,7 @@ class GIN_EXPORT V8Platform : public NON_EXPORTED_BASE(v8::Platform) {
const char** arg_names,
const uint8_t* arg_types,
const uint64_t* arg_values,
+ std::unique_ptr<v8::ConvertableToTraceFormat>*,
jochen (gone - plz use gerrit) 2016/09/26 15:04:37 please add an args name
alph 2016/09/26 22:06:56 Done.
unsigned int flags) override;
void UpdateTraceEventDuration(const uint8_t* category_enabled_flag,
const char* name,
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | gin/v8_platform.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698