Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: gin/public/v8_platform.h

Issue 2368483002: [gin] Add ConvertableToTraceFormatWrapper (Closed)
Patch Set: Align with v8-platform change. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | gin/v8_platform.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_V8_PLATFORM_H_ 5 #ifndef GIN_PUBLIC_V8_PLATFORM_H_
6 #define GIN_PUBLIC_V8_PLATFORM_H_ 6 #define GIN_PUBLIC_V8_PLATFORM_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 26 matching lines...) Expand all
37 uint64_t AddTraceEvent(char phase, 37 uint64_t AddTraceEvent(char phase,
38 const uint8_t* category_enabled_flag, 38 const uint8_t* category_enabled_flag,
39 const char* name, 39 const char* name,
40 const char* scope, 40 const char* scope,
41 uint64_t id, 41 uint64_t id,
42 uint64_t bind_id, 42 uint64_t bind_id,
43 int32_t num_args, 43 int32_t num_args,
44 const char** arg_names, 44 const char** arg_names,
45 const uint8_t* arg_types, 45 const uint8_t* arg_types,
46 const uint64_t* arg_values, 46 const uint64_t* arg_values,
47 std::unique_ptr<v8::ConvertableToTraceFormat>*,
jochen (gone - plz use gerrit) 2016/09/26 15:04:37 please add an args name
alph 2016/09/26 22:06:56 Done.
47 unsigned int flags) override; 48 unsigned int flags) override;
48 void UpdateTraceEventDuration(const uint8_t* category_enabled_flag, 49 void UpdateTraceEventDuration(const uint8_t* category_enabled_flag,
49 const char* name, 50 const char* name,
50 uint64_t handle) override; 51 uint64_t handle) override;
51 52
52 void AddTraceStateObserver(v8::Platform::TraceStateObserver*) override; 53 void AddTraceStateObserver(v8::Platform::TraceStateObserver*) override;
53 void RemoveTraceStateObserver(v8::Platform::TraceStateObserver*) override; 54 void RemoveTraceStateObserver(v8::Platform::TraceStateObserver*) override;
54 55
55 private: 56 private:
56 friend struct base::DefaultLazyInstanceTraits<V8Platform>; 57 friend struct base::DefaultLazyInstanceTraits<V8Platform>;
57 58
58 V8Platform(); 59 V8Platform();
59 ~V8Platform() override; 60 ~V8Platform() override;
60 61
61 DISALLOW_COPY_AND_ASSIGN(V8Platform); 62 DISALLOW_COPY_AND_ASSIGN(V8Platform);
62 }; 63 };
63 64
64 } // namespace gin 65 } // namespace gin
65 66
66 #endif // GIN_PUBLIC_V8_PLATFORM_H_ 67 #endif // GIN_PUBLIC_V8_PLATFORM_H_
OLDNEW
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | gin/v8_platform.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698