Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2368443002:
WebVR: Strings for insecure content warning display (Closed)
DescriptionWebVR: Strings for insecure content warning display
On WebVR pages loaded over insecure transport, show a small "Not secure"
warning overlay permanently, and a transient more verbose warning for a
short time on first entering the page.
The implementation will use these localized strings, to be submitted
separately. (See https://codereview.chromium.org/2363553003 for
context.)
R=blundell@chromium.org, bshe@chromium.org
BUG=
Committed: https://crrev.com/801601cb2944e82342f0a1939ad3e76f9eba4902
Cr-Commit-Position: refs/heads/master@{#420535}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Simplify "desc" text #Messages
Total messages: 20 (9 generated)
Split out from https://codereview.chromium.org/2363553003/ , containing the strings only.
high level: I feel these strings belong to: chrome/browser/browser_resources.grd as they are used in a browser UI? https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:386: + <message name="IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is displayed temporarily as a large toast on first entering a WebVR page over non-secure transport. (The IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT message is shown above it and will remain permanently.)"> Do you need the text in parenthesis in desc? If you do, perhaps the real text to replace IDS_* string. The desc is intended to be viewed by translator I believe and they might not know what the IDS_* refers to.
Description was changed from ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= ========== to ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= ==========
klausw@chromium.org changed reviewers: - blundell@chromium.org
On 2016/09/22 22:27:25, bshe wrote: > high level: I feel these strings belong to: > chrome/browser/browser_resources.grd > as they are used in a browser UI? > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > chrome/app/generated_resources.grd:386: + <message > name="IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is > displayed temporarily as a large toast on first entering a WebVR page over > non-secure transport. (The IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT > message is shown above it and will remain permanently.)"> > Do you need the text in parenthesis in desc? If you do, perhaps the real text to > replace IDS_* string. The desc is intended to be viewed by translator I believe > and they might not know what the IDS_* refers to. Sorry, it looks like chrome/app/generated_resources.grd is better than browser_resources.grd. ignore my previous comment about generated_resources.grd
On 2016/09/22 22:27:25, bshe wrote: > high level: I feel these strings belong to: > chrome/browser/browser_resources.grd > as they are used in a browser UI? > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > chrome/app/generated_resources.grd:386: + <message > name="IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is > displayed temporarily as a large toast on first entering a WebVR page over > non-secure transport. (The IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT > message is shown above it and will remain permanently.)"> > Do you need the text in parenthesis in desc? If you do, perhaps the real text to > replace IDS_* string. The desc is intended to be viewed by translator I believe > and they might not know what the IDS_* refers to. I've simplified the desc text, PTAL.
On 2016/09/22 22:45:51, klausw1 wrote: > On 2016/09/22 22:27:25, bshe wrote: > > high level: I feel these strings belong to: > > chrome/browser/browser_resources.grd > > as they are used in a browser UI? > > > > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > > File chrome/app/generated_resources.grd (right): > > > > > https://codereview.chromium.org/2368443002/diff/1/chrome/app/generated_resour... > > chrome/app/generated_resources.grd:386: + <message > > name="IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that > is > > displayed temporarily as a large toast on first entering a WebVR page over > > non-secure transport. (The > IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT > > message is shown above it and will remain permanently.)"> > > Do you need the text in parenthesis in desc? If you do, perhaps the real text > to > > replace IDS_* string. The desc is intended to be viewed by translator I > believe > > and they might not know what the IDS_* refers to. > > I've simplified the desc text, PTAL. lgtm
The CQ bit was checked by klausw@chromium.org
The CQ bit was unchecked by klausw@chromium.org
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= ========== to ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= ========== to ========== WebVR: Strings for insecure content warning display On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= Committed: https://crrev.com/801601cb2944e82342f0a1939ad3e76f9eba4902 Cr-Commit-Position: refs/heads/master@{#420535} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/801601cb2944e82342f0a1939ad3e76f9eba4902 Cr-Commit-Position: refs/heads/master@{#420535} |
