Issue 23684061: Detect illegal class member names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23684061: Detect illegal class member names (Closed)

Created:
7 years, 3 months ago by hausner

Modified:
7 years, 3 months ago

Reviewers:
Michael Lippautz (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Detect illegal class member names Make it a compile time error if a class member has the same name as the class. Fixes issue 13236.

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

LGTM (though not sure if interns are allowed to do that :))

7 years, 3 months ago (2013-09-12 20:31:34 UTC) #2

hausner

7 years, 3 months ago (2013-09-12 20:46:24 UTC) #3

Don't worry, I won't tell anyone :)

gcl commit had a hiccup halfway through the commit, and somehow this got checked
in as issue 23513044.

https://codereview.chromium.org/23513044/

Expand Messages | Collapse Messages