Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chromeos/network/shill_property_handler.h

Issue 23684042: Eliminate NetworkManagerChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler.h
diff --git a/chromeos/network/shill_property_handler.h b/chromeos/network/shill_property_handler.h
index cc9133b3dd45db63b1f1dcbda56d4f7f71f23826..14e0ca5aa6d5cabda82a6963631b6946ec5aa981 100644
--- a/chromeos/network/shill_property_handler.h
+++ b/chromeos/network/shill_property_handler.h
@@ -75,9 +75,8 @@ class CHROMEOS_EXPORT ShillPropertyHandler
virtual void CheckPortalListChanged(
const std::string& check_portal_list) = 0;
- // Called when one or more manager properties (e.g. a technology list)
- // changes.
- virtual void NotifyManagerPropertyChanged() = 0;
+ // Called when one a technology list changes.
pneubeck (no reviews) 2013/09/11 20:13:35 fix comment
stevenjb 2013/09/11 21:23:46 Done.
+ virtual void TechnologyListChanged() = 0;
// Called when a managed state list has changed, after properties for any
// new entries in the list have been received and
@@ -143,8 +142,7 @@ class CHROMEOS_EXPORT ShillPropertyHandler
void CheckPendingStateListUpdates(const std::string& key);
// Called form OnPropertyChanged() and ManagerPropertiesCallback().
- // Returns true if observers should be notified.
- bool ManagerPropertyChanged(const std::string& key,
+ void ManagerPropertyChanged(const std::string& key,
const base::Value& value);
// Requests properties for new entries in the list for |type| as follows:

Powered by Google App Engine
This is Rietveld 408576698