Eliminate NetworkManagerChanged

chromeos/network/shill_property_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_SHILL_PROPERTY_HANDLER_H_
 #define CHROMEOS_NETWORK_SHILL_PROPERTY_HANDLER_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 57 matching lines @@
     // Called when a property for a watched device has changed.
     virtual void UpdateDeviceProperty(
         const std::string& device_path,
         const std::string& key,
         const base::Value& value) = 0;
 
     // Called when the list of devices with portal check enabled changes.
     virtual void CheckPortalListChanged(
          const std::string& check_portal_list) = 0;
 
-    // Called when one or more manager properties (e.g. a technology list)
-    // changes.
-    virtual void NotifyManagerPropertyChanged() = 0;
+    // Called when one a technology list changes.

[pneubeck (no reviews), 2013/09/11 20:13:35]

fix comment

[stevenjb, 2013/09/11 21:23:46]

Done.

+    virtual void TechnologyListChanged() = 0;
 
     // Called when a managed state list has changed, after properties for any
     // new entries in the list have been received and
     // UpdateManagedStateProperties has been called for each new entry.
     virtual void ManagedStateListChanged(ManagedState::ManagedType type) = 0;
 
    protected:
     virtual ~Listener() {}
   };
 
@@ skipping 45 matching lines @@
   // Callback for dbus method fetching properties.
   void ManagerPropertiesCallback(DBusMethodCallStatus call_status,
                                  const base::DictionaryValue& properties);
 
   // Notifies the listener when a ManagedStateList has changed and all pending
   // updates have been received. |key| can either identify the list that
   // has changed or an empty string if multiple lists may have changed.
   void CheckPendingStateListUpdates(const std::string& key);
 
   // Called form OnPropertyChanged() and ManagerPropertiesCallback().
-  // Returns true if observers should be notified.
-  bool ManagerPropertyChanged(const std::string& key,
+  void ManagerPropertyChanged(const std::string& key,
                               const base::Value& value);
 
   // Requests properties for new entries in the list for |type| as follows:
   // * Any new Device objects for MANAGED_TYPE_DEVICE
   // * Any new Service objects for MANAGED_TYPE_NETWORK
   // * Additional new Service objects for MANAGED_TYPE_FAVORITE that were not
   //   requested for MANAGED_TYPE_NETWORK (i.e. only request objects once).
   // For this to avoid duplicate requests, this must be called with
   // MANAGED_TYPE_NETWORK before MANAGED_TYPE_FAVORITE.
   void UpdateProperties(ManagedState::ManagedType type,
@@ skipping 70 matching lines @@
   std::set<std::string> enabling_technologies_;
   std::set<std::string> uninitialized_technologies_;
 
   DISALLOW_COPY_AND_ASSIGN(ShillPropertyHandler);
 };
 
 }  // namespace internal
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_SHILL_PROPERTY_HANDLER_H_