Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chromeos/network/network_state_handler.h

Issue 23684042: Eliminate NetworkManagerChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 9ad3ac87e097547556e826c91478b83e83ae4c75..ca0f30dc18833b7b5032ae543b42bb7e89791025 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -199,7 +199,9 @@ class CHROMEOS_EXPORT NetworkStateHandler
// Set the list of devices on which portal check is enabled.
void SetCheckPortalList(const std::string& check_portal_list);
- const std::string& check_portal_list() const { return check_portal_list_; }
+ const std::string& GetCheckPortalListForTest() const {
+ return check_portal_list_;
+ }
// Generates a DictionaryValue of all NetworkState properties. Currently
// provided for debugging purposes only.
@@ -257,8 +259,8 @@ class CHROMEOS_EXPORT NetworkStateHandler
virtual void CheckPortalListChanged(
const std::string& check_portal_list) OVERRIDE;
- // Sends NetworkManagerChanged() to observers and logs an event.
- virtual void NotifyManagerPropertyChanged() OVERRIDE;
+ // Called by ShillPropertyHandler when a technology list changes.
+ virtual void TechnologyListChanged() OVERRIDE;
// Called by |shill_property_handler_| when the service or device list has
// changed and all entries have been updated. This updates the list and
@@ -282,6 +284,9 @@ class CHROMEOS_EXPORT NetworkStateHandler
void UpdateNetworkStateProperties(NetworkState* network,
const base::DictionaryValue& properties);
+ // Sends DeviceListChanged() to observers and logs an event.
+ void NotifyDeviceListChanged();
+
// Non-const getters for managed entries. These are const so that they can
// be called by Get[Network|Device]State, even though they return non-const
// pointers.

Powered by Google App Engine
This is Rietveld 408576698