Eliminate NetworkManagerChanged

chrome/browser/chromeos/login/screens/network_screen.h

Index: chrome/browser/chromeos/login/screens/network_screen.h
diff --git a/chrome/browser/chromeos/login/screens/network_screen.h b/chrome/browser/chromeos/login/screens/network_screen.h
index c8fae5c148812c3f26c8eeb63868ca8360525b96..e7beeaa0b92a52adcba9981f0dbb7ee71a4877f8 100644
--- a/chrome/browser/chromeos/login/screens/network_screen.h
+++ b/chrome/browser/chromeos/login/screens/network_screen.h
@@ -34,7 +34,7 @@ class NetworkScreen : public WizardScreen,
   virtual std::string GetName() const OVERRIDE;
 
   // NetworkStateHandlerObserver implementation:
-  virtual void NetworkManagerChanged() OVERRIDE;
+  virtual void NetworkListChanged() OVERRIDE;

[pneubeck (no reviews), 2013/09/11 20:13:35]

Is this required to get notifications if a network changes to state Connecting ?

[stevenjb, 2013/09/11 21:23:46]

This is probably a bit of overkill, but seemed harmless. I looked at the history
and this originally obsevred NetworkLibrary::OnNetworkManagerChanged, which
triggered whenever the Services list changed, so this is the equivalent of that.

To answer your question, yes this will get triggered whenever an "active"
(connected or connecting) network changes connection state, since that will
affect the list order.

[pneubeck (no reviews), 2013/09/12 12:33:25]

Hm. This doesn't sound reliable. Couldn't there be cases where the list order
doesn't change, but a network (e.g. the only network) changes from state idle to
connecting?

[stevenjb, 2013/09/12 19:42:50]

OK, I looked at the code more closely. It doesn't appear to care about the list
at all, only ConnectedNetworkByType / ConnectingNetworkByType. I will change
this to observe NetworkConnectionStateChanged() instead of NetworkListChaned().

   virtual void DefaultNetworkChanged(const NetworkState* network) OVERRIDE;
 
   // NetworkScreenActor::Delegate implementation: