Eliminate NetworkManagerChanged

chrome/browser/chromeos/login/screens/network_screen.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
@@ skipping 16 matching lines @@
   NetworkScreen(ScreenObserver* screen_observer, NetworkScreenActor* actor);
   virtual ~NetworkScreen();
 
   // WizardScreen implementation:
   virtual void PrepareToShow() OVERRIDE;
   virtual void Show() OVERRIDE;
   virtual void Hide() OVERRIDE;
   virtual std::string GetName() const OVERRIDE;
 
   // NetworkStateHandlerObserver implementation:
-  virtual void NetworkManagerChanged() OVERRIDE;
+  virtual void NetworkListChanged() OVERRIDE;

[pneubeck (no reviews), 2013/09/11 20:13:35]

Is this required to get notifications if a network changes to state Connecting ?

[stevenjb, 2013/09/11 21:23:46]

This is probably a bit of overkill, but seemed harmless. I looked at the history
and this originally obsevred NetworkLibrary::OnNetworkManagerChanged, which
triggered whenever the Services list changed, so this is the equivalent of that.

To answer your question, yes this will get triggered whenever an "active"
(connected or connecting) network changes connection state, since that will
affect the list order.

[pneubeck (no reviews), 2013/09/12 12:33:25]

Hm. This doesn't sound reliable. Couldn't there be cases where the list order
doesn't change, but a network (e.g. the only network) changes from state idle to
connecting?

[stevenjb, 2013/09/12 19:42:50]

OK, I looked at the code more closely. It doesn't appear to care about the list
at all, only ConnectedNetworkByType / ConnectingNetworkByType. I will change
this to observe NetworkConnectionStateChanged() instead of NetworkListChaned().

   virtual void DefaultNetworkChanged(const NetworkState* network) OVERRIDE;
 
   // NetworkScreenActor::Delegate implementation:
   virtual void OnActorDestroyed(NetworkScreenActor* actor) OVERRIDE;
   virtual void OnContinuePressed() OVERRIDE;
 
   NetworkScreenActor* actor() const { return actor_; }
 
  protected:
   // Subscribes NetworkScreen to the network change notification,
@@ skipping 45 matching lines @@
 
   NetworkScreenActor* actor_;
   scoped_ptr<login::NetworkStateHelper> network_state_helper_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkScreen);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_