Ensures NOTIFICATION_APP_TERMINATING at the end of InProcessBrowserTest.

Ensures NOTIFICATION_APP_TERMINATING at the end of InProcessBrowserTest.

BUG=285402
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221666

[sky, 2013-09-05 15:33:45]

https://codereview.chromium.org/23684031/diff/1/chrome/test/base/in_process_b...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/23684031/diff/1/chrome/test/base/in_process_b...
chrome/test/base/in_process_browser_test.cc:462: chrome::NotifyAppTerminating();
Might this result in sending out notification twice?

[Jun Mukai, 2013-09-05 18:46:56]

https://codereview.chromium.org/23684031/diff/1/chrome/test/base/in_process_b...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/23684031/diff/1/chrome/test/base/in_process_b...
chrome/test/base/in_process_browser_test.cc:462: chrome::NotifyAppTerminating();
On 2013/09/05 15:33:45, sky wrote:
> Might this result in sending out notification twice?

No, as far as I see.

Usually app-terminating will be emitted through chrome::AttemptExit() below, and
I cannot find no other code paths to emit it. I also injected a log into
NotifyAppTerminating(), and at least some test doesn't print the log.

It also seems that NotifyAppTerminating() uses a static boolean flag to avoid
notifying twice, so I think it's safe.

[sky, 2013-09-05 20:37:22]

LGTM

[commit-bot: I haz the power, 2013-09-05 20:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/23684031/1

[commit-bot: I haz the power, 2013-09-06 09:49:18]

Change committed as 221666