Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5872)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 23684031: Ensures NOTIFICATION_APP_TERMINATING at the end of InProcessBrowserTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 014386cc509d1cf70126790a46ea1ce6aa7d0e4a..47e8c2a6fee41c9d9cab70b6d4caea436e7c26ab 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -458,8 +458,10 @@ void InProcessBrowserTest::RunTestOnMainThreadLoop() {
}
void InProcessBrowserTest::QuitBrowsers() {
- if (chrome::GetTotalBrowserCount() == 0)
+ if (chrome::GetTotalBrowserCount() == 0) {
+ chrome::NotifyAppTerminating();
sky 2013/09/05 15:33:45 Might this result in sending out notification twic
Jun Mukai 2013/09/05 18:46:56 No, as far as I see. Usually app-terminating will
return;
+ }
// Invoke AttemptExit on a running message loop.
// AttemptExit exits the message loop after everything has been
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698