Issue 23684023: Move the WebPluginResourceClient interface to its own header. Also fix up method order in webplugin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23684023: Move the WebPluginResourceClient interface to its own header. Also fix up method order in webplugin… (Closed)

Created:
7 years, 3 months ago by jam

Modified:
7 years, 3 months ago

Reviewers:
tburkard

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the WebPluginResourceClient interface to its own header. Also fix up method order in webplugin_proxy.h and change WebKit::WebCanvas usage to SkCanvas. R=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221269

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -81 lines)			Patch
M	content/child/npapi/plugin_instance.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/npapi/plugin_stream_url.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/npapi/webplugin.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl_android.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl_aura.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl_mac.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl_win.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
A	content/child/npapi/webplugin_resource_client.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	content/content_child.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/plugin/webplugin_delegate_stub.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/plugin/webplugin_proxy.h	View	3 chunks	+23 lines, -38 lines	0 comments	Download
M	content/renderer/npapi/webplugin_delegate_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/npapi/webplugin_delegate_proxy.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/npapi/webplugin_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tburkard

7 years, 3 months ago (2013-09-04 01:02:30 UTC) #2

lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages