Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: content/plugin/webplugin_proxy.h

Issue 23684023: Move the WebPluginResourceClient interface to its own header. Also fix up method order in webplugin… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/plugin/webplugin_delegate_stub.cc ('k') | content/renderer/npapi/webplugin_delegate_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/webplugin_proxy.h
===================================================================
--- content/plugin/webplugin_proxy.h (revision 220951)
+++ content/plugin/webplugin_proxy.h (working copy)
@@ -52,16 +52,12 @@
// WebPlugin overrides
virtual void SetWindow(gfx::PluginWindowHandle window) OVERRIDE;
-
- // Whether input events should be sent to the delegate.
virtual void SetAcceptsInputEvents(bool accepts) OVERRIDE;
-
virtual void WillDestroyWindow(gfx::PluginWindowHandle window) OVERRIDE;
#if defined(OS_WIN)
void SetWindowlessData(HANDLE pump_messages_event,
gfx::NativeViewId dummy_activation_window);
#endif
-
virtual void CancelResource(unsigned long id) OVERRIDE;
virtual void Invalidate() OVERRIDE;
virtual void InvalidateRect(const gfx::Rect& rect) OVERRIDE;
@@ -74,30 +70,6 @@
const std::string& cookie) OVERRIDE;
virtual std::string GetCookies(const GURL& url,
const GURL& first_party_for_cookies) OVERRIDE;
-
- // class-specific methods
-
- // Returns a WebPluginResourceClient object given its id, or NULL if no
- // object with that id exists.
- WebPluginResourceClient* GetResourceClient(int id);
-
- // Returns the id of the renderer that contains this plugin.
- int GetRendererId();
-
- // Returns the id of the associated render view.
- int host_render_view_routing_id() const {
- return host_render_view_routing_id_;
- }
-
- // For windowless plugins, paints the given rectangle into the local buffer.
- void Paint(const gfx::Rect& rect);
-
- // Callback from the renderer to let us know that a paint occurred.
- void DidPaint();
-
- // Notification received on a plugin issued resource request creation.
- void OnResourceCreated(int resource_id, WebPluginResourceClient* client);
-
virtual void HandleURLRequest(const char* url,
const char* method,
const char* target,
@@ -125,24 +97,37 @@
virtual void StartIme() OVERRIDE;
virtual WebPluginAcceleratedSurface*
GetAcceleratedSurface(gfx::GpuPreference gpu_preference) OVERRIDE;
-
- //----------------------------------------------------------------------
- // Accelerated plugin implementation which renders via the compositor.
-
- // Tells the renderer, and from there the GPU process, that the plugin
- // is using accelerated rather than software rendering.
virtual void AcceleratedPluginEnabledRendering() OVERRIDE;
-
- // Tells the renderer, and from there the GPU process, that the plugin
- // allocated the given IOSurface to be used as its backing store.
virtual void AcceleratedPluginAllocatedIOSurface(int32 width,
int32 height,
uint32 surface_id) OVERRIDE;
virtual void AcceleratedPluginSwappedIOSurface() OVERRIDE;
#endif
-
virtual void URLRedirectResponse(bool allow, int resource_id) OVERRIDE;
+ // class-specific methods
+
+ // Returns a WebPluginResourceClient object given its id, or NULL if no
+ // object with that id exists.
+ WebPluginResourceClient* GetResourceClient(int id);
+
+ // Returns the id of the renderer that contains this plugin.
+ int GetRendererId();
+
+ // Returns the id of the associated render view.
+ int host_render_view_routing_id() const {
+ return host_render_view_routing_id_;
+ }
+
+ // For windowless plugins, paints the given rectangle into the local buffer.
+ void Paint(const gfx::Rect& rect);
+
+ // Callback from the renderer to let us know that a paint occurred.
+ void DidPaint();
+
+ // Notification received on a plugin issued resource request creation.
+ void OnResourceCreated(int resource_id, WebPluginResourceClient* client);
+
#if defined(OS_WIN) && !defined(USE_AURA)
// Retrieves the IME status from a windowless plug-in and sends it to a
// renderer process. A renderer process will convert the coordinates from
« no previous file with comments | « content/plugin/webplugin_delegate_stub.cc ('k') | content/renderer/npapi/webplugin_delegate_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698