Move EnumerateModulesModel work to the blocking pool.

Move EnumerateModulesModel work to the blocking pool.

This fixes a FILE thread shutdown hang.

BUG=644918
Committed: https://crrev.com/210ad10bec0f4b6e3e392206824e234a7a36cf6e
Cr-Commit-Position: refs/heads/master@{#421016}

[chrisha, 2016-09-26 19:21:48]

chrisha@chromium.org changed reviewers:
+ gab@chromium.org

[chrisha, 2016-09-26 19:21:49]

PTAL?

[chrisha, 2016-09-26 19:32:17]

The CQ bit was checked by chrisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 19:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-26 19:37:21]

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
File chrome/browser/win/enumerate_modules_model.cc (right):

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
chrome/browser/win/enumerate_modules_model.cc:385: runner->PostTask(FROM_HERE,
Since you don't need a SequencedTaskRunner for multiple tasks you can use
SequencedWorkerPool::PostWorkerTaskWithShutdownBehavior() directly without
getting a temporary SequencedTaskRunner

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
chrome/browser/win/enumerate_modules_model.cc:739: }
I'm unclear on why this change is required/related?

[chrisha, 2016-09-26 19:58:17]

Another quick look?

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
File chrome/browser/win/enumerate_modules_model.cc (right):

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
chrome/browser/win/enumerate_modules_model.cc:385: runner->PostTask(FROM_HERE,
On 2016/09/26 19:37:21, gab wrote:
> Since you don't need a SequencedTaskRunner for multiple tasks you can use
> SequencedWorkerPool::PostWorkerTaskWithShutdownBehavior() directly without
> getting a temporary SequencedTaskRunner 

Ah, even better, thanks.

https://codereview.chromium.org/2368393004/diff/1/chrome/browser/win/enumerat...
chrome/browser/win/enumerate_modules_model.cc:739: }
On 2016/09/26 19:37:21, gab wrote:
> I'm unclear on why this change is required/related?

Oops, that was meant to be another CL. Will move it there.

[gab, 2016-09-26 20:34:24]

lgtm, thanks

[chrisha, 2016-09-26 20:41:12]

The CQ bit was checked by chrisha@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:41:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:08:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-26 22:11:25]

Description was changed from

==========
Move EnumerateModulesModel work to the blocking pool.

This fixes a FILE thread shutdown hang.

BUG=644918
==========

to

==========
Move EnumerateModulesModel work to the blocking pool.

This fixes a FILE thread shutdown hang.

BUG=644918

Committed: https://crrev.com/210ad10bec0f4b6e3e392206824e234a7a36cf6e
Cr-Commit-Position: refs/heads/master@{#421016}
==========

[commit-bot: I haz the power, 2016-09-26 22:11:25]

Patchset 2 (id:??) landed as
https://crrev.com/210ad10bec0f4b6e3e392206824e234a7a36cf6e
Cr-Commit-Position: refs/heads/master@{#421016}