Move EnumerateModulesModel work to the blocking pool.

chrome/browser/win/enumerate_modules_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WIN_ENUMERATE_MODULES_MODEL_H_
 #define CHROME_BROWSER_WIN_ENUMERATE_MODULES_MODEL_H_
 
 #include <memory>
 #include <utility>
 #include <vector>
@@ skipping 121 matching lines @@
   ~ModuleEnumerator();
 
   // Start scanning the loaded module list (if a scan is not already in
   // progress). This function does not block while reading the module list and
   // will notify when done by calling the DoneScanning method of |observer_|.
   void ScanNow(ModulesVector* list);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(EnumerateModulesTest, CollapsePath);
 
-  // This function does the actual file scanning work on the FILE thread. It
+  // This function does the actual file scanning work in the blocking pool. It
   // enumerates all loaded modules in the process and other modules of interest,
   // such as the registered Winsock LSP modules and stores them in
   // |enumerated_modules_|. It then normalizes the module info and matches them
   // against a blacklist of known bad modules. Finally, notifies the observer
   // that the enumeration is complete by invoking DoneScanning.
   void ScanImpl();
 
   // Enumerate all modules loaded into the Chrome process.
   void EnumerateLoadedModules();
 
@@ skipping 60 matching lines @@
 // both currently loaded modules (called DLLs on Windows) and modules 'of
 // interest', such as WinSock LSP modules. This class also marks each module
 // as benign or suspected bad or outright bad, using a supplied blacklist that
 // is currently hard-coded.
 //
 // To use this class, grab the singleton pointer and call ScanNow().
 // Then wait to get notified through MODULE_LIST_ENUMERATED when the list is
 // ready.
 //
 // The member functions of this class may only be used from the UI thread. The
-// bulk of the work is actually performed on the FILE thread.
+// bulk of the work is actually performed in the blocking pool with
+// CONTINUE_ON_SHUTDOWN semantics, as the WinCrypt functions can effectively
+// block arbitrarily during shutdown.
 //
 // TODO(chrisha): If this logic is ever extended to other platforms, then make
 // this file generic for all platforms, and remove the precompiler logic in
 // app_menu_icon_controller.*.
 class EnumerateModulesModel {
  public:
   // UMA histogram constants.
   enum UmaModuleConflictHistogramOptions {
     ACTION_BUBBLE_SHOWN = 0,
     ACTION_BUBBLE_LEARN_MORE,
@@ skipping 66 matching lines @@
   EnumerateModulesModel();
   ~EnumerateModulesModel();
 
   // Called on the UI thread when the helper class is done scanning. The
   // ModuleEnumerator that calls this must not do any work after causing this
   // function to be called, as the EnumerateModulesModel may delete the
   // ModuleEnumerator.
   void DoneScanning();
 
   // The vector containing all the modules enumerated. Will be normalized and
-  // any bad modules will be marked. Written to on the FILE thread by the
+  // any bad modules will be marked. Written to from the blocking pool by the
   // |module_enumerator_|, read from on the UI thread by this class.
   ModuleEnumerator::ModulesVector enumerated_modules_;
 
-  // The object responsible for enumerating the modules on the FILE thread.
-  // Only used from the UI thread. This ends up internally doing its work on the
-  // FILE thread.
+  // The object responsible for enumerating the modules in the blocking pool.
+  // Only used from the UI thread. This ends up internally doing its work in the
+  // blocking pool.
   std::unique_ptr<ModuleEnumerator> module_enumerator_;
 
   // Whether the conflict notification has been acknowledged by the user. Only
   // modified on the UI thread.
   bool conflict_notification_acknowledged_;
 
   // The number of confirmed bad modules (not including suspected bad ones)
   // found during last scan. Only modified on the UI thread.
   int confirmed_bad_modules_detected_;
 
   // The number of bad modules the user needs to be aggressively notified about.
   // Only modified on the UI thread.
   int modules_to_notify_about_;
 
   // The number of suspected bad modules (not including confirmed bad ones)
   // found during last scan. Only modified on the UI thread.
   int suspected_bad_modules_detected_;
 
   base::ObserverList<Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(EnumerateModulesModel);
 };
 
 #endif  // CHROME_BROWSER_WIN_ENUMERATE_MODULES_MODEL_H_