Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2368263002:
These calls to SkRandom are not sequenced. (Closed)
DescriptionThese calls to SkRandom are not sequenced.
This is why we see two versions of this GM: some compilers evaluate the
rand.nextRangeScalar() calls left to right, others right to left.
Remember this bug?
BUG=skia:3241
(https://codereview.chromium.org/1157943006 fixed hittestpath last year.)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002
Committed: https://skia.googlesource.com/skia/+/1c127cc3e1d8603bf970211f1d85a1ce3b6fb138
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextScalarRange() calls left to right, others right to left. BUG=skia: ========== to ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextScalarRange() calls left to right, others right to left. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ==========
Description was changed from ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextScalarRange() calls left to right, others right to left. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ========== to ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ========== to ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ==========
Description was changed from ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ========== to ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 (https://codereview.chromium.org/1157943006 fixed hittestpath last year.) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ==========
mtklein@chromium.org changed reviewers: + jvanverth@google.com
brianosman@google.com changed reviewers: + brianosman@google.com
lgtm
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Unfortunately, the Clang warning that can catch this sort of thing
(-Wunsequenced) is on---by default---and not catching it. It seems to work for
simple things like printf("%d %d\n", i++, i++), but not for more complex
scenarios.
Message was sent while issue was closed.
Description was changed from ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 (https://codereview.chromium.org/1157943006 fixed hittestpath last year.) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 ========== to ========== These calls to SkRandom are not sequenced. This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 (https://codereview.chromium.org/1157943006 fixed hittestpath last year.) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 Committed: https://skia.googlesource.com/skia/+/1c127cc3e1d8603bf970211f1d85a1ce3b6fb138 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1c127cc3e1d8603bf970211f1d85a1ce3b6fb138 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
