Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: gm/beziers.cpp

Issue 2368263002: These calls to SkRandom are not sequenced. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/beziers.cpp
diff --git a/gm/beziers.cpp b/gm/beziers.cpp
index cf65c0b22c3897c3be9bc162f1c9ffe2229072f5..ffc3ba65fdcf94da9d3132b500d89a48513cf7e7 100755
--- a/gm/beziers.cpp
+++ b/gm/beziers.cpp
@@ -18,8 +18,11 @@ constexpr SkScalar SH = SkIntToScalar(H);
static void rnd_quad(SkPath* p, SkPaint* paint, SkRandom& rand) {
p->moveTo(rand.nextRangeScalar(0, W), rand.nextRangeScalar(0, H));
for (int x = 0; x < 2; ++x) {
- p->quadTo(rand.nextRangeScalar(W / 4, W), rand.nextRangeScalar(0, H),
- rand.nextRangeScalar(0, W), rand.nextRangeScalar(H / 4, H));
+ auto a = rand.nextRangeScalar(W/4, W),
+ b = rand.nextRangeScalar( 0, H),
+ c = rand.nextRangeScalar( 0, W),
+ d = rand.nextRangeScalar(H/4, H);
+ p->quadTo(a,b,c,d);
}
paint->setColor(rand.nextU());
SkScalar width = rand.nextRangeScalar(1, 5);
@@ -29,11 +32,17 @@ static void rnd_quad(SkPath* p, SkPaint* paint, SkRandom& rand) {
}
static void rnd_cubic(SkPath* p, SkPaint* paint, SkRandom& rand) {
- p->moveTo(rand.nextRangeScalar(0, W), rand.nextRangeScalar(0, H));
+ auto a = rand.nextRangeScalar(0,W),
+ b = rand.nextRangeScalar(0,H);
+ p->moveTo(a,b);
for (int x = 0; x < 2; ++x) {
- p->cubicTo(rand.nextRangeScalar(W / 4, W), rand.nextRangeScalar(0, H),
- rand.nextRangeScalar(0, W), rand.nextRangeScalar(H / 4, H),
- rand.nextRangeScalar(W / 4, W), rand.nextRangeScalar(H / 4, H));
+ auto c = rand.nextRangeScalar(W/4, W),
+ d = rand.nextRangeScalar( 0, H),
+ e = rand.nextRangeScalar( 0, W),
+ f = rand.nextRangeScalar(H/4, H),
+ g = rand.nextRangeScalar(W/4, W),
+ h = rand.nextRangeScalar(H/4, H);
+ p->cubicTo(c,d,e,f,g,h);
}
paint->setColor(rand.nextU());
SkScalar width = rand.nextRangeScalar(1, 5);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698