Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2368243005: Remove unmapped Apps. histograms from AppInfoDialog (Closed)

Created:
4 years, 2 months ago by benwells
Modified:
4 years, 2 months ago
Reviewers:
sashab
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unmapped Apps. histograms from AppInfoDialog BUG=643562 Committed: https://crrev.com/ac6c09843c7a5567de5cf0e11d7f915287e74ab2 Cr-Commit-Position: refs/heads/master@{#421710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
benwells
4 years, 2 months ago (2016-09-27 06:40:00 UTC) #4
sashab
Haha, someone sent me a link today to the webstore that included ?utm_source=AppInfoDialog and I ...
4 years, 2 months ago (2016-09-29 00:11:10 UTC) #7
benwells
On 2016/09/29 00:11:10, sashab wrote: > Haha, someone sent me a link today to the ...
4 years, 2 months ago (2016-09-29 01:09:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368243005/1
4 years, 2 months ago (2016-09-29 01:10:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 01:48:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 01:51:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac6c09843c7a5567de5cf0e11d7f915287e74ab2
Cr-Commit-Position: refs/heads/master@{#421710}

Powered by Google App Engine
This is Rietveld 408576698