Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 2368243005: Remove unmapped Apps. histograms from AppInfoDialog (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index 169f9ab199ba0393cf62f2bcab00074605d78d76..0a86b3e66aa9a89cd1ed570626729c1f3f419775 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -8,7 +8,6 @@
#include "base/bind.h"
#include "base/command_line.h"
-#include "base/metrics/histogram_macros.h"
#include "build/build_config.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile.h"
@@ -77,13 +76,6 @@ void ShowAppInfoInAppList(gfx::NativeWindow parent,
Profile* profile,
const extensions::Extension* app,
const base::Closure& close_callback) {
- UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForType",
- app->GetType(),
- extensions::Manifest::NUM_LOAD_TYPES);
- UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForLocation",
- app->location(),
- extensions::Manifest::NUM_LOCATIONS);
-
views::View* app_info_view = new AppInfoDialog(parent, profile, app);
views::DialogDelegate* dialog =
CreateAppListContainerForView(app_info_view, close_callback);
@@ -123,13 +115,6 @@ AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,
profile_(profile),
app_id_(app->id()),
extension_registry_(NULL) {
- UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForType",
- app->GetType(),
- extensions::Manifest::NUM_LOAD_TYPES);
- UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForLocation",
- app->location(),
- extensions::Manifest::NUM_LOCATIONS);
-
views::BoxLayout* layout =
new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0);
SetLayoutManager(layout);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698