Issue 2368243003: Disable Reader Mode when requesting desktop site

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2368243003: Disable Reader Mode when requesting desktop site (Closed)

Created:
4 years, 2 months ago by mdjones

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Disable Reader Mode when requesting desktop site If requesting a desktop site on mobile, Reader Mode will no longer trigger unless its heuristic is set to ALWAYS_TRUE. BUG=647086 Review-Url: https://codereview.chromium.org/2342873005 Cr-Commit-Position: refs/heads/master@{#419562} (cherry picked from commit 591e68b15907d0489d344083411f24b1c2c81809) Committed: https://chromium.googlesource.com/chromium/src/+/868f7da2beed900db05262c85e986fefa4b9e4c1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java	View	3 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_distiller/tab_utils_android.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

mdjones

4 years, 2 months ago (2016-09-26 15:32:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
868f7da2beed900db05262c85e986fefa4b9e4c1.