Disable Reader Mode when requesting desktop site

Disable Reader Mode when requesting desktop site

If requesting a desktop site on mobile, Reader Mode will no longer
trigger unless its heuristic is set to ALWAYS_TRUE.

BUG=647086
Committed: https://crrev.com/591e68b15907d0489d344083411f24b1c2c81809
Cr-Commit-Position: refs/heads/master@{#419562}

[mdjones, 2016-09-16 17:30:01]

mdjones@chromium.org changed reviewers:
+ wychen@chromium.org

[mdjones, 2016-09-16 17:30:02]

ptal

[wychen, 2016-09-16 22:56:35]

Thanks for the quick fix! LGTM.

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
(right):

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java:65:
* @return True if distiller is ALWAYS_TRUE.
if heuristic is ALWAYS_TRUE.

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java:67:
public static boolean isDistillerAlwaysTrue() {
isHeuristicAlwaysTrue() is probably easier to understand.

[mdjones, 2016-09-19 15:42:19]

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
(right):

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java:65:
* @return True if distiller is ALWAYS_TRUE.
On 2016/09/16 22:56:35, wychen wrote:
> if heuristic is ALWAYS_TRUE.

Done.

https://codereview.chromium.org/2342873005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java:67:
public static boolean isDistillerAlwaysTrue() {
On 2016/09/16 22:56:35, wychen wrote:
> isHeuristicAlwaysTrue() is probably easier to understand.

Done.

[mdjones, 2016-09-19 15:43:24]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-09-19 15:43:24]

The patchset sent to the CQ was uploaded after l-g-t-m from wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2342873005/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-19 15:43:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 17:02:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:02:40]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mdjones, 2016-09-19 21:00:14]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-09-19 21:00:14]

The patchset sent to the CQ was uploaded after l-g-t-m from wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2342873005/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2016-09-19 21:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:36:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 21:38:39]

Description was changed from

==========
Disable Reader Mode when requesting desktop site

If requesting a desktop site on mobile, Reader Mode will no longer
trigger unless its heuristic is set to ALWAYS_TRUE.

BUG=647086
==========

to

==========
Disable Reader Mode when requesting desktop site

If requesting a desktop site on mobile, Reader Mode will no longer
trigger unless its heuristic is set to ALWAYS_TRUE.

BUG=647086

Committed: https://crrev.com/591e68b15907d0489d344083411f24b1c2c81809
Cr-Commit-Position: refs/heads/master@{#419562}
==========

[commit-bot: I haz the power, 2016-09-19 21:38:40]

Patchset 4 (id:??) landed as
https://crrev.com/591e68b15907d0489d344083411f24b1c2c81809
Cr-Commit-Position: refs/heads/master@{#419562}