Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2368213002: Remove AudioOutputDeviceEnumerator. Replace usage with MediaDevicesManager. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, miu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AudioOutputDeviceEnumerator. Replace usage with MediaDevicesManager. Drive-by: Stop using std::array literals to specify devices to enumerate. Use device types as indexes. This makes it easier to understand what is being requested and removes reliance on the order of elements in the array. BUG=647660 Committed: https://crrev.com/63931c20853b821d960649bb5ccd9b2f0332f245 Cr-Commit-Position: refs/heads/master@{#420959}

Patch Set 1 : Remove AudioOutputDeviceEnumerator. Replace usage with MediaDevicesManager. #

Patch Set 2 : Remove BoolDeviceTypes std::array literals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -735 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/renderer_host/media/audio_output_device_enumerator.h View 1 chunk +0 lines, -136 lines 0 comments Download
D content/browser/renderer_host/media/audio_output_device_enumerator.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc View 1 chunk +0 lines, -207 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 4 chunks +23 lines, -26 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 5 chunks +114 lines, -120 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 7 chunks +12 lines, -25 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_manager.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_manager_unittest.cc View 1 12 chunks +35 lines, -12 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 5 chunks +7 lines, -14 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (17 generated)
Guido Urdaneta
Hi, PTAL
4 years, 2 months ago (2016-09-26 10:29:55 UTC) #4
tommi (sloooow) - chröme
lgtm but I would like it if someone else could take a look to make ...
4 years, 2 months ago (2016-09-26 12:41:18 UTC) #9
Guido Urdaneta
Moved olka@ from cc to actual reviewer.
4 years, 2 months ago (2016-09-26 13:34:01 UTC) #11
o1ka
On 2016/09/26 13:34:01, Guido Urdaneta wrote: > Moved olka@ from cc to actual reviewer. Just ...
4 years, 2 months ago (2016-09-26 14:28:18 UTC) #12
o1ka
On 2016/09/26 14:28:18, o1ka wrote: > On 2016/09/26 13:34:01, Guido Urdaneta wrote: > > Moved ...
4 years, 2 months ago (2016-09-26 15:36:40 UTC) #14
Guido Urdaneta
avi@: can you rs / look at BUILD.gn ?
4 years, 2 months ago (2016-09-26 16:26:32 UTC) #16
Avi (use Gerrit)
stampity stamp lgtm
4 years, 2 months ago (2016-09-26 17:23:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368213002/40001
4 years, 2 months ago (2016-09-26 17:25:42 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-09-26 19:22:24 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 19:24:50 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63931c20853b821d960649bb5ccd9b2f0332f245
Cr-Commit-Position: refs/heads/master@{#420959}

Powered by Google App Engine
This is Rietveld 408576698