Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.cc

Issue 2368213002: Remove AudioOutputDeviceEnumerator. Replace usage with MediaDevicesManager. (Closed)
Patch Set: Remove BoolDeviceTypes std::array literals Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/media_stream_manager.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/media_stream_manager.cc
diff --git a/content/browser/renderer_host/media/media_stream_manager.cc b/content/browser/renderer_host/media/media_stream_manager.cc
index 74018626f842f0464bff8ec79f2c434650f28ccb..df4566bb5dd3389909ef3d806e2a3c1599129a6b 100644
--- a/content/browser/renderer_host/media/media_stream_manager.cc
+++ b/content/browser/renderer_host/media/media_stream_manager.cc
@@ -484,13 +484,6 @@ AudioInputDeviceManager* MediaStreamManager::audio_input_device_manager() {
return audio_input_device_manager_.get();
}
-AudioOutputDeviceEnumerator*
-MediaStreamManager::audio_output_device_enumerator() {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- DCHECK(audio_output_device_enumerator_.get());
- return audio_output_device_enumerator_.get();
-}
-
MediaDevicesManager* MediaStreamManager::media_devices_manager() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(media_devices_manager_.get());
@@ -769,9 +762,10 @@ void MediaStreamManager::DoEnumerateDevices(const std::string& label) {
if (request->audio_type() == MEDIA_DEVICE_AUDIO_OUTPUT) {
DCHECK_EQ(MEDIA_NO_SERVICE, request->video_type());
request->SetState(MEDIA_DEVICE_AUDIO_OUTPUT, MEDIA_REQUEST_STATE_REQUESTED);
+ MediaDevicesManager::BoolDeviceTypes devices_to_enumerate;
+ devices_to_enumerate[MEDIA_DEVICE_TYPE_AUDIO_OUTPUT] = true;
media_devices_manager_->EnumerateDevices(
- {{false /* audio input */, false /* video input*/,
- true /* audio output */}},
+ devices_to_enumerate,
base::Bind(&MediaStreamManager::AudioOutputDevicesEnumerated,
base::Unretained(this), label));
return;
@@ -980,8 +974,11 @@ void MediaStreamManager::StartEnumeration(DeviceRequest* request,
// base::Unretained is safe here because MediaStreamManager is deleted on the
// UI thread, after the IO thread has been stopped.
DCHECK(request_audio_input || request_video_input);
+ MediaDevicesManager::BoolDeviceTypes devices_to_enumerate;
+ devices_to_enumerate[MEDIA_DEVICE_TYPE_AUDIO_INPUT] = request_audio_input;
+ devices_to_enumerate[MEDIA_DEVICE_TYPE_VIDEO_INPUT] = request_video_input;
media_devices_manager_->EnumerateDevices(
- {{request_audio_input, request_video_input, false /* no audio output */}},
+ devices_to_enumerate,
base::Bind(&MediaStreamManager::DevicesEnumerated, base::Unretained(this),
request_audio_input, request_video_input, label));
}
@@ -1486,9 +1483,6 @@ void MediaStreamManager::InitializeDeviceManagersOnIOThread() {
video_capture_manager_->Register(this, device_task_runner_);
#endif
- audio_output_device_enumerator_.reset(new AudioOutputDeviceEnumerator(
- audio_manager_, AudioOutputDeviceEnumerator::CACHE_POLICY_NO_CACHING));
-
media_devices_manager_.reset(
new MediaDevicesManager(audio_manager_, video_capture_manager_, this));
}
@@ -1797,7 +1791,6 @@ void MediaStreamManager::WillDestroyCurrentMessageLoop() {
audio_input_device_manager_ = NULL;
video_capture_manager_ = NULL;
- audio_output_device_enumerator_ = NULL;
media_devices_manager_ = NULL;
g_media_stream_manager_tls_ptr.Pointer()->Set(NULL);
}
« no previous file with comments | « content/browser/renderer_host/media/media_stream_manager.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698