Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2368193002: Introduce HTMLInputElement::m_hasDirtyValue. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce HTMLInputElement::m_hasDirtyValue. Add a bool flag to represent the dirty flag [1]. We replace !m_valueIfDirty.isNull() for dirty flag checking with the new flag. This CL has no behavior changes. This CL is a preparation to make m_valueIfDirty a permanent storage of |value| IDL attribute. [1] https://html.spec.whatwg.org/multipage/forms.html#concept-input-value-dirty-flag [2] https://html.spec.whatwg.org/multipage/forms.html#dom-input-value BUG=633074 Committed: https://crrev.com/930e066130dc8621d4b25c8bfe14d8fff315404e Cr-Commit-Position: refs/heads/master@{#421100}

Patch Set 1 #

Patch Set 2 : Fix Windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 7 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tkent
keishi, would you review this please?
4 years, 2 months ago (2016-09-26 08:18:54 UTC) #4
keishi
LGTM
4 years, 2 months ago (2016-09-27 01:12:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368193002/20001
4 years, 2 months ago (2016-09-27 01:14:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 04:18:07 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 04:21:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/930e066130dc8621d4b25c8bfe14d8fff315404e
Cr-Commit-Position: refs/heads/master@{#421100}

Powered by Google App Engine
This is Rietveld 408576698