Adjust CSS property maximum tracking to be more clang-format friendly.

Adjust CSS property maximum tracking to be more clang-format friendly.

BUG=649969
Committed: https://crrev.com/dd1a7ad9f71c9e1d990f651f8f1cc15c0130f1e1
Cr-Commit-Position: refs/heads/master@{#420911}

[dcheng, 2016-09-25 20:43:35]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2016-09-25 20:43:36]

Still need to figure out what to do with the remaining PRESUBMIT.py check in
here, since clang-format puts case statements on their own line. But this one is
easy-ish at least.

[dcheng, 2016-09-25 20:43:39]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-25 20:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-09-25 21:08:13]

Lgtm

Huh why was this a function?

In general, I think if some Python script tries to parse a c++ file to extract
information, we should probably have that information in some other form and
then generate the cpp file from there (and have py load it directly)

https://codereview.chromium.org/2368103003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/2368103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.cpp:582: // 2. Update
kMaximumCSSSampleId() with the new maximum value.
No parens

[commit-bot: I haz the power, 2016-09-25 21:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-25 21:51:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2016-09-25 23:52:59]

On 2016/09/25 21:08:13, Nico wrote:
> Lgtm
> 
> Huh why was this a function?
> 
> In general, I think if some Python script tries to parse a c++ file to extract
> information, we should probably have that information in some other form and
> then generate the cpp file from there (and have py load it directly)

I have no idea why this is a function.

As for making this all generated, it's a bit tricky and I'd like to avoid tying
clang-format to fixing this up. The CSS enum values in question are all
generated from
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSPr...,
and there's no real correlation to the order they are currently defined and the
UMA reporting value. Parsing C++ is inherently fragile (there's a fair number of
false positives from check-webkit-style)... but this is the easiest approach for
now.

https://codereview.chromium.org/2368103003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/2368103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.cpp:582: // 2. Update
kMaximumCSSSampleId() with the new maximum value.
On 2016/09/25 21:08:12, Nico wrote:
> No parens

Done.

[dcheng, 2016-09-25 23:53:17]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-09-25 23:53:18]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2368103003/#ps40001
(title: "Remove parens")

[commit-bot: I haz the power, 2016-09-25 23:53:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-09-25 23:54:06]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-25 23:54:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 02:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 02:04:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dcheng, 2016-09-26 03:30:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-26 03:30:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 06:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 06:07:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dcheng, 2016-09-26 07:42:07]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-26 07:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 10:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 10:17:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nico, 2016-09-26 15:30:21]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-26 15:30:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 16:56:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-26 16:57:40]

Description was changed from

==========
Adjust CSS property maximum tracking to be more clang-format friendly.

BUG=649969
==========

to

==========
Adjust CSS property maximum tracking to be more clang-format friendly.

BUG=649969

Committed: https://crrev.com/dd1a7ad9f71c9e1d990f651f8f1cc15c0130f1e1
Cr-Commit-Position: refs/heads/master@{#420911}
==========

[commit-bot: I haz the power, 2016-09-26 16:57:41]

Patchset 3 (id:??) landed as
https://crrev.com/dd1a7ad9f71c9e1d990f651f8f1cc15c0130f1e1
Cr-Commit-Position: refs/heads/master@{#420911}

[dcheng, 2016-10-01 02:13:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2383153003/ by dcheng@chromium.org.

The reason for reverting is: Yet another test..