Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2368073002: PaymentRequest: Add payer name field to payer info editor. (android) (Closed)
Patch Set: PaymentRequest: Add payer name field to payer info editor. (android) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 591ddea33dda67f818abbed21dca8678d7c2359b..7c57aa1914e289005977c625b7d68cc5f34f3677 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -283,6 +283,9 @@ CHAR-LIMIT guidelines:
<message name="IDS_AUTOFILL_PROFILE_EDITOR_COUNTRY" desc="Label for a spinner input field containing a list of countries or regions [CHAR-LIMIT=32]">
Country/Region
</message>
+ <message name="IDS_AUTOFILL_PROFILE_EDITOR_NAME" desc="Label for text input field containing a name. [CHAR-LIMIT=32]">
please use gerrit instead 2016/10/13 20:20:33 s/a name/the full name of a person/ Translators n
zino 2016/10/14 19:01:56 Oh, you're right. Done.
+ Name
+ </message>
please use gerrit instead 2016/10/13 20:20:33 Please move this down to <!-- Payments --> section
zino 2016/10/14 19:01:56 Done.
<message name="IDS_AUTOFILL_PROFILE_EDITOR_EMAIL_ADDRESS" desc="Label for text input field containing an e-mail address. [CHAR-LIMIT=32]">
Email
</message>
@@ -2513,10 +2516,10 @@ You can control the Physical Web in Chrome Settings.
<message name="IDS_PAYMENTS_CONTACT_DETAILS_LABEL" desc="The title for the section that lets the user select how they can be contacted.">
Contact info
</message>
- <message name="IDS_PAYMENTS_ADD_CONTACT_DETAILS_LABEL" desc="The title of the dialog for user to add new contact information, such as email address or phone number.">
+ <message name="IDS_PAYMENTS_ADD_CONTACT_DETAILS_LABEL" desc="The title of the dialog for user to add new contact information, such as payer name or email address and phone number.">
please use gerrit instead 2016/10/13 20:20:33 "...such as the user's full name, an email address
zino 2016/10/14 19:01:56 Done.
Add contact info
</message>
- <message name="IDS_PAYMENTS_EDIT_CONTACT_DETAILS_LABEL" desc="The title of the dialog for user to edit their contact information, such as email address or phone number.">
+ <message name="IDS_PAYMENTS_EDIT_CONTACT_DETAILS_LABEL" desc="The title of the dialog for user to edit their contact information, such as payer name or email address or phone number.">
please use gerrit instead 2016/10/13 20:20:33 Ditto
zino 2016/10/14 19:01:56 Done.
Edit contact info
</message>
<message name="IDS_PAYMENTS_SHIPPING_SUMMARY_LABEL" desc="The title for the section of shipping information.">
@@ -2549,6 +2552,9 @@ You can control the Physical Web in Chrome Settings.
<message name="IDS_PAYMENTS_FIELD_REQUIRED_VALIDATION_MESSAGE" desc="The text that informs the user that an input field is required.">
Required field
</message>
+ <message name="IDS_PAYMENTS_NAME_INVALID_VALIDATION_MESSAGE" desc="The text that informs the user that the payer name they have entered is not valid.">
+ Invalid name
+ </message>
please use gerrit instead 2016/10/13 20:20:33 The only validation for names is that it's not emp
zino 2016/10/14 19:01:56 Done.
<message name="IDS_PAYMENTS_PHONE_INVALID_VALIDATION_MESSAGE" desc="The text that informs the user that the phone number they have entered is not valid.">
Invalid phone number
</message>
@@ -2558,7 +2564,7 @@ You can control the Physical Web in Chrome Settings.
<message name="IDS_PAYMENTS_CARD_NUMBER_INVALID_VALIDATION_MESSAGE" desc="The text that informs the user that the credit card number they have entered is not valid.">
Invalid card number
</message>
- <message name="IDS_PAYMENTS_ADD_CONTACT" desc="Text on a button that lets a user add new contact details, like phone number or email address.">
+ <message name="IDS_PAYMENTS_ADD_CONTACT" desc="Text on a button that lets a user add new contact details, like payer name or phone number or email address.">
please use gerrit instead 2016/10/13 20:20:33 s/payer name/user's full name/
zino 2016/10/14 19:01:56 Done.
Add contact info
</message>
<message name="IDS_PAYMENTS_SELECT_SHIPPING_ADDRESS_FOR_SHIPPING_METHODS" desc="Text implying that a user needs to pick a shipping address to see the shipping methods.">

Powered by Google App Engine
This is Rietveld 408576698