Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h

Issue 2368043002: [SPv2] Separate SVG root viewport clip from overflow clip. (Closed)
Patch Set: none Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
index 0e47c7782c4516f1107ac74f67890ad6a2fd1bec..96821423415aaa50fd8b2469af09fd0a2c6c265c 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
+++ b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
@@ -83,9 +83,12 @@ public:
// [ css clip fixed position]
// |
// +--- [ overflow clip ]
+ // |
+ // +--- [ SVG root viewport clip ]
const ClipPaintPropertyNode* cssClip() const { return m_cssClip.get(); }
const ClipPaintPropertyNode* cssClipFixedPosition() const { return m_cssClipFixedPosition.get(); }
const ClipPaintPropertyNode* overflowClip() const { return m_overflowClip.get(); }
+ const ClipPaintPropertyNode* svgRootViewportClip() const { return m_svgRootViewportClip.get(); }
// This is a complete set of property nodes that should be used as a starting point to paint
// this layout object. It is needed becauase some property inherits from the containing block,
@@ -112,6 +115,7 @@ public:
void clearCssClip() { m_cssClip = nullptr; }
void clearCssClipFixedPosition() { m_cssClipFixedPosition = nullptr; }
void clearOverflowClip() { m_overflowClip = nullptr; }
+ void clearSvgRootViewportClip() { m_svgRootViewportClip = nullptr; }
void clearPerspective() { m_perspective = nullptr; }
void clearSvgLocalToBorderBoxTransform() { m_svgLocalToBorderBoxTransform = nullptr; }
void clearScrollTranslation() { m_scrollTranslation = nullptr; }
@@ -137,6 +141,7 @@ public:
template <typename... Args> ClipPaintPropertyNode* createOrUpdateCssClip(Args&&... args) { return createOrUpdateProperty(m_cssClip, std::forward<Args>(args)...); }
template <typename... Args> ClipPaintPropertyNode* createOrUpdateCssClipFixedPosition(Args&&... args) { return createOrUpdateProperty(m_cssClipFixedPosition, std::forward<Args>(args)...); }
template <typename... Args> ClipPaintPropertyNode* createOrUpdateOverflowClip(Args&&... args) { return createOrUpdateProperty(m_overflowClip, std::forward<Args>(args)...); }
+ template <typename... Args> ClipPaintPropertyNode* createOrUpdateSvgRootViewportClip(Args&&... args) { return createOrUpdateProperty(m_svgRootViewportClip, std::forward<Args>(args)...); }
void setLocalBorderBoxProperties(std::unique_ptr<LocalBorderBoxProperties> properties) { m_localBorderBoxProperties = std::move(properties); }
@@ -159,6 +164,7 @@ private:
RefPtr<ClipPaintPropertyNode> m_cssClip;
RefPtr<ClipPaintPropertyNode> m_cssClipFixedPosition;
RefPtr<ClipPaintPropertyNode> m_overflowClip;
+ RefPtr<ClipPaintPropertyNode> m_svgRootViewportClip;
RefPtr<TransformPaintPropertyNode> m_perspective;
// TODO(pdr): Only LayoutSVGRoot needs this and it should be moved there.
RefPtr<TransformPaintPropertyNode> m_svgLocalToBorderBoxTransform;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698