Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2367973002: Log compressed size of HTTP/2 requests. (Closed)

Created:
4 years, 3 months ago by Bence
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log compressed size of HTTP/2 requests. Protected by FLAGS_chromium_http2_flag_log_compressed_size. This CL lands server change 133714721 by yasong. BUG=488484 Committed: https://crrev.com/766306f5e9b9c799703d9ff98384cd86553eb8b9 Cr-Commit-Position: refs/heads/master@{#421185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -8 lines) Patch
M net/quic/core/quic_header_list.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/core/quic_header_list.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/spdy/header_coalescer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/hpack/hpack_decoder.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/spdy/spdy_deframer_visitor.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 2 chunks +11 lines, -1 line 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 7 chunks +29 lines, -6 lines 0 comments Download
M net/spdy/spdy_headers_handler_interface.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/spdy/spdy_no_op_visitor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 2 months ago (2016-09-25 11:02:21 UTC) #6
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-09-26 17:56:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367973002/1
4 years, 2 months ago (2016-09-26 18:09:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148332)
4 years, 2 months ago (2016-09-26 21:17:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367973002/1
4 years, 2 months ago (2016-09-27 12:04:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 12:54:26 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:57:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/766306f5e9b9c799703d9ff98384cd86553eb8b9
Cr-Commit-Position: refs/heads/master@{#421185}

Powered by Google App Engine
This is Rietveld 408576698