Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/spdy/spdy_deframer_visitor.cc

Issue 2367973002: Log compressed size of HTTP/2 requests. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/hpack/hpack_decoder.cc ('k') | net/spdy/spdy_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_deframer_visitor.cc
diff --git a/net/spdy/spdy_deframer_visitor.cc b/net/spdy/spdy_deframer_visitor.cc
index 3d7a5d73b85a46f078acc6d8715bbcbc67ea43c9..e99114fba71b6540d0eee3f83077a597e76bf9df 100644
--- a/net/spdy/spdy_deframer_visitor.cc
+++ b/net/spdy/spdy_deframer_visitor.cc
@@ -195,6 +195,8 @@ class SpdyTestDeframerImpl : public SpdyTestDeframer,
void OnHeaderBlockStart() override;
void OnHeader(StringPiece key, StringPiece value) override;
void OnHeaderBlockEnd(size_t header_bytes_parsed) override;
+ void OnHeaderBlockEnd(size_t header_bytes_parsed,
+ size_t compressed_header_bytes_parsed) override;
protected:
void AtDataEnd();
@@ -842,6 +844,18 @@ void SpdyTestDeframerImpl::OnHeaderBlockEnd(size_t header_bytes_parsed) {
got_hpack_end_ = true;
}
+void SpdyTestDeframerImpl::OnHeaderBlockEnd(
+ size_t /* header_bytes_parsed */,
+ size_t /* compressed_header_bytes_parsed */) {
+ CHECK(headers_);
+ CHECK(frame_type_ == HEADERS || frame_type_ == CONTINUATION ||
+ frame_type_ == PUSH_PROMISE)
+ << " frame_type_=" << Http2FrameTypeToString(frame_type_);
+ CHECK(end_);
+ CHECK(!got_hpack_end_);
+ got_hpack_end_ = true;
+}
+
class LoggingSpdyDeframerDelegate : public SpdyDeframerVisitorInterface {
public:
explicit LoggingSpdyDeframerDelegate(
« no previous file with comments | « net/spdy/hpack/hpack_decoder.cc ('k') | net/spdy/spdy_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698