Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 7ed9437eb12539c5f71807233a45a6d0d2980ca6..2942fe8ac738593790d5f10ddcf307166fd15459 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -379,7 +379,7 @@ void CallModuleMethod(const std::string& module_name,
const std::string& method_name,
const base::ListValue* args,
ChromeV8Context* context) {
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(context->isolate());
v8::Context::Scope context_scope(context->v8_context());
scoped_ptr<content::V8ValueConverter> converter(
@@ -646,7 +646,7 @@ v8::Handle<v8::Object> Dispatcher::GetOrCreateObject(
}
void Dispatcher::AddOrRemoveBindingsForContext(ChromeV8Context* context) {
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(context->isolate());
v8::Context::Scope context_scope(context->v8_context());
// TODO(kalman): Make the bindings registration have zero overhead then run

Powered by Google App Engine
This is Rietveld 408576698