Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index cfdbd8fcfb5feab5b5599fb0e5a301034579108e..041578c42902eb8a9547c5ca1d768640e23ba4fa 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -353,7 +353,7 @@ void ExtensionHelper::OnAddMessageToConsole(ConsoleMessageLevel level,
}
void ExtensionHelper::OnAppWindowClosed() {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
v8::Handle<v8::Context> script_context =
render_view()->GetWebView()->mainFrame()->mainWorldScriptContext();
ChromeV8Context* chrome_v8_context =

Powered by Google App Engine
This is Rietveld 408576698