Refactor KeySystems code to call a function to populate the info.

content/public/renderer/content_renderer_client.h

Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index 4eea8a3c12830d31f4dc1f0ff8c75a715c8e34ef..81ed14618b0b559951289835b0e1386c45d49825 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -6,6 +6,7 @@
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
+#include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
@@ -51,6 +52,7 @@ namespace content {
 
 class RenderView;
 class SynchronousCompositor;
+struct KeySystemInfo;
 struct WebPluginInfo;
 
 // Embedder API for participating in renderer logic.
@@ -244,6 +246,9 @@ class CONTENT_EXPORT ContentRendererClient {
   // Returns true if the page at |url| can use Pepper MediaStream APIs.
   virtual bool AllowPepperMediaStreamAPI(const GURL& url);
 
+  // Gives the embedder a chance to register the key system(s) it supports.
+  virtual void AddKeySystems(std::vector<KeySystemInfo>* key_systems);

[xhwang, 2013/09/04 21:48:40]

It's not clear from the signature and comment what this function is supposed to
do. Update the comment that the function is supposed to populate |key_systems|?
Also, can we make the function name more explicit? e.g. GenerateKeySystemInfo?

[ddorwin, 2013/09/06 18:30:00]

The name and comment are modeled after existing methods in ContentClient:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

I tried to at least make it clear that |key_systems| should be populated. Let me
know if you have other suggestions.

+
   // Returns true if we should report a detailed message (including a stack
   // trace) for console [logs|errors|exceptions]. |source| is the WebKit-
   // reported source for the error; this can point to a page or a script,