Refactor KeySystems code to call a function to populate the info.

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
+#include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/page_transition_types.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/public/web/WebNavigationPolicy.h"
 #include "third_party/WebKit/public/web/WebNavigationType.h"
 #include "third_party/WebKit/public/web/WebPageVisibilityState.h"
 #include "v8/include/v8.h"
@@ skipping 25 matching lines @@
 class WebThemeEngine;
 class WebURLRequest;
 struct WebPluginParams;
 struct WebURLError;
 }
 
 namespace content {
 
 class RenderView;
 class SynchronousCompositor;
+struct KeySystemInfo;
 struct WebPluginInfo;
 
 // Embedder API for participating in renderer logic.
 class CONTENT_EXPORT ContentRendererClient {
  public:
   virtual ~ContentRendererClient() {}
 
   // Notifies us that the RenderThread has been created.
   virtual void RenderThreadStarted() {}
 
@@ skipping 173 matching lines @@
   // pp::FileIO::RequestOSFileHandle.
   virtual bool IsPluginAllowedToCallRequestOSFileHandle(
       WebKit::WebPluginContainer* container);
 
   // Returns whether BrowserPlugin should be allowed within the |container|.
   virtual bool AllowBrowserPlugin(WebKit::WebPluginContainer* container);
 
   // Returns true if the page at |url| can use Pepper MediaStream APIs.
   virtual bool AllowPepperMediaStreamAPI(const GURL& url);
 
+  // Gives the embedder a chance to register the key system(s) it supports.
+  virtual void AddKeySystems(std::vector<KeySystemInfo>* key_systems);

[xhwang, 2013/09/04 21:48:40]

It's not clear from the signature and comment what this function is supposed to
do. Update the comment that the function is supposed to populate |key_systems|?
Also, can we make the function name more explicit? e.g. GenerateKeySystemInfo?

[ddorwin, 2013/09/06 18:30:00]

The name and comment are modeled after existing methods in ContentClient:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

I tried to at least make it clear that |key_systems| should be populated. Let me
know if you have other suggestions.

+
   // Returns true if we should report a detailed message (including a stack
   // trace) for console [logs|errors|exceptions]. |source| is the WebKit-
   // reported source for the error; this can point to a page or a script,
   // and can be external or internal.
   virtual bool ShouldReportDetailedMessageForSource(
       const base::string16& source) const;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_