Subzero, MIPS32: Binding intrablock labels, unconditional branch

Subzero, MIPS32: Binding intrablock labels, unconditional branch

This patch was supposed to be a part of patch with instruction encodings.

R=stichnot@chromium.org

Author: Jaydeep Patil
Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=58eeedf7a97346c147c6206fe6364d79be3f7a04

[obucinac, 2016-09-24 05:51:58]

Description was changed from

==========
Subzero, MIPS32: Binding intrablock labels, unconditional branch

This patch was supposed to be a part of patch with instruction
encodings.

Author: Jaydeep Patil
==========

to

==========
Subzero, MIPS32: Binding intrablock labels, unconditional branch

This patch was supposed to be a part of patch with instruction encodings.

Author: Jaydeep Patil
==========

[obucinac, 2016-09-24 05:51:58]

obucinac@gmail.com changed reviewers:
+ eholk@chromium.org, jaydeep.patil@imgtec.com, jpp@chromium.org,
kschimpf@google.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[jaydeep.patil, 2016-09-24 08:05:18]

https://codereview.chromium.org/2367743004/diff/1/src/IceInstMIPS32.cpp
File src/IceInstMIPS32.cpp (right):

https://codereview.chromium.org/2367743004/diff/1/src/IceInstMIPS32.cpp#newco...
src/IceInstMIPS32.cpp:278: //  if (Asm->needsTextFixup())
Commented code

[Jim Stichnoth, 2016-09-24 15:07:31]

> Author: Jaydeep Patil

Does this mean that Jaydeep should be used as the author when the CL is landed?

[obucinac, 2016-09-24 15:13:51]

On 2016/09/24 15:07:31, stichnot wrote:
> > Author: Jaydeep Patil
> 
> Does this mean that Jaydeep should be used as the author when the CL is
landed?

Yes

[obucinac, 2016-09-26 17:16:25]

https://codereview.chromium.org/2367743004/diff/1/src/IceInstMIPS32.cpp
File src/IceInstMIPS32.cpp (right):

https://codereview.chromium.org/2367743004/diff/1/src/IceInstMIPS32.cpp#newco...
src/IceInstMIPS32.cpp:278: //  if (Asm->needsTextFixup())
On 2016/09/24 08:05:18, jaydeep.patil wrote:
> Commented code

Removed.

Implementation will be added in a separate patch.

[Jim Stichnoth, 2016-09-27 03:48:07]

lgtm

[Jim Stichnoth, 2016-09-27 03:48:19]

Description was changed from

==========
Subzero, MIPS32: Binding intrablock labels, unconditional branch

This patch was supposed to be a part of patch with instruction encodings.

Author: Jaydeep Patil
==========

to

==========
Subzero, MIPS32: Binding intrablock labels, unconditional branch

This patch was supposed to be a part of patch with instruction encodings.

R=stichnot@chromium.org

Author: Jaydeep Patil
Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-27 03:48:21]

Committed patchset #2 (id:20001) manually as
58eeedf7a97346c147c6206fe6364d79be3f7a04 (presubmit successful).