Subzero, MIPS32: Binding intrablock labels, unconditional branch

src/IceInstMIPS32.cpp

 //===- subzero/src/IceInstMips32.cpp - Mips32 instruction implementation --===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 /// \file
@@ skipping 255 matching lines @@
 }
 
 void InstMIPS32Label::emit(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << getLabelName() << ":";
 }
 
 void InstMIPS32Label::emitIAS(const Cfg *Func) const {
-  (void)Func;
-  llvm_unreachable("Not yet implemented");
+  auto *Asm = Func->getAssembler<MIPS32::AssemblerMIPS32>();
+  Asm->bindLocalLabel(this, Number);
+  //  if (Asm->needsTextFixup())

[jaydeep.patil, 2016/09/24 08:05:18]

Commented code

[obucinac, 2016/09/26 17:16:25]

Removed.

Implementation will be added in a separate patch.

+  //    emitUsingTextFixup(Func);
 }
 
 InstMIPS32Call::InstMIPS32Call(Cfg *Func, Variable *Dest, Operand *CallTarget)
     : InstMIPS32(Func, InstMIPS32::Call, 1, Dest) {
   HasSideEffects = true;
   addSource(CallTarget);
 }
 
 InstMIPS32Mov::InstMIPS32Mov(Cfg *Func, Variable *Dest, Operand *Src)
     : InstMIPS32(Func, InstMIPS32::Mov, 2, Dest) {
@@ skipping 124 matching lines @@
   assert(RA->getRegNum() == RegMIPS32::Reg_RA);
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
          "jr"
          "\t";
   RA->emit(Func);
 }
 
 void InstMIPS32Br::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<MIPS32::AssemblerMIPS32>();
-  if (isUnconditionalBranch()) {
+  if (Label != nullptr) {
+    // Intra-block branches are of kind bcc
+    Asm->bcc(Predicate, getSrc(0), getSrc(1),
+             Asm->getOrCreateLocalLabel(Label->getNumber()));
+  } else if (isUnconditionalBranch()) {
     Asm->b(Asm->getOrCreateCfgNodeLabel(getTargetFalse()->getIndex()));
   } else {
     switch (Predicate) {
     default:
       break;
     case CondMIPS32::EQ:
     case CondMIPS32::NE:
       Asm->bcc(Predicate, getSrc(0), getSrc(1),
                Asm->getOrCreateCfgNodeLabel(getTargetFalse()->getIndex()));
       break;
     case CondMIPS32::EQZ:
     case CondMIPS32::NEZ:
     case CondMIPS32::LEZ:
     case CondMIPS32::LTZ:
     case CondMIPS32::GEZ:
     case CondMIPS32::GTZ:
       Asm->bzc(Predicate, getSrc(0),
                Asm->getOrCreateCfgNodeLabel(getTargetFalse()->getIndex()));
       break;
     }
+    if (getTargetTrue()) {
+      Asm->b(Asm->getOrCreateCfgNodeLabel(getTargetTrue()->getIndex()));
+    }
   }
 }
 
 void InstMIPS32Br::emit(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
          "b" << InstMIPS32CondAttributes[Predicate].EmitString << "\t";
   if (Label != nullptr) {
@@ skipping 669 matching lines @@
   Asm->xor_(getDest(), getSrc(0), getSrc(1));
 }
 
 template <> void InstMIPS32Xori::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<MIPS32::AssemblerMIPS32>();
   Asm->xori(getDest(), getSrc(0), Imm);
 }
 
 } // end of namespace MIPS32
 } // end of namespace Ice