Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2367723003: Revert of Re-enable rate limiting for Windows Crashpad (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable rate limiting for Windows Crashpad (patchset #1 id:1 of https://codereview.chromium.org/2365833003/ ) Reason for revert: After further discussion, decided against taking this in 53 Original issue's description: > Re-enable rate limiting for Windows Crashpad > > Chrome can get itself into crash loops that cause massive numbers of > uploads. We'd like to have UMA to see what we're dropping, but for > the time being, mitigate by re-instituting the Mac-style 1/hr upload > limit. > > BUG=crashpad:23, 647464 > > Review-Url: https://codereview.chromium.org/2332103002 > Cr-Commit-Position: refs/heads/master@{#418063} > (cherry picked from commit d922b3cacfcee6958d71de501a8ced7c25801965) > > Committed: https://chromium.googlesource.com/chromium/src/+/c1490fd145eda148dd788e554426aa7cb7fde5b2 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=crashpad:23, 647464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/crash/content/app/crashpad_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scottmg
Created Revert of Re-enable rate limiting for Windows Crashpad
4 years, 3 months ago (2016-09-23 18:51:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367723003/1
4 years, 3 months ago (2016-09-23 18:52:32 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:57:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698