Re-enable rate limiting for Windows Crashpad

Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
Committed: https://crrev.com/d922b3cacfcee6958d71de501a8ced7c25801965
Cr-Commit-Position: refs/heads/master@{#418063}

[scottmg, 2016-09-12 20:43:30]

Description was changed from

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
==========

to

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
==========

[scottmg, 2016-09-12 20:43:30]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org, siggi@chromium.org, wfh@chromium.org

[Mark Mentovai, 2016-09-12 20:45:13]

LGTM

[scottmg, 2016-09-12 20:45:41]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-09-12 20:46:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-09-12 20:47:10]

Oh, just saw your mail on doing 20/day. Do you think it's worth changing that to
be Crashpad's default? I guess that'll just be confusing for Mac stability
numbers without being a whole lot better though.

[scottmg, 2016-09-12 20:47:51]

On 2016/09/12 20:47:10, scottmg wrote:
> Oh, just saw your mail on doing 20/day. Do you think it's worth changing that
to
> be Crashpad's default? I guess that'll just be confusing for Mac stability
> numbers without being a whole lot better though.

(I think I'll land this all the same so that we can do a simple merge to have
some throttling on the client anyway.)

[Mark Mentovai, 2016-09-12 20:48:28]

We can start with 1/hour as a band-aid, but I think we should aim for some
scheme that lets more than a single report through at a time.

On Mon, Sep 12, 2016 at 4:47 PM, <scottmg@chromium.org> wrote:

> Oh, just saw your mail on doing 20/day. Do you think it's worth changing
> that to
> be Crashpad's default? I guess that'll just be confusing for Mac stability
> numbers without being a whole lot better though.
>
> https://codereview.chromium.org/2332103002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-09-12 21:49:13]

Description was changed from

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
==========

to

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
==========

[commit-bot: I haz the power, 2016-09-12 21:49:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-12 21:51:10]

Description was changed from

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23
==========

to

==========
Re-enable rate limiting for Windows Crashpad

Chrome can get itself into crash loops that cause massive numbers of
uploads. We'd like to have UMA to see what we're dropping, but for
the time being, mitigate by re-instituting the Mac-style 1/hr upload
limit.

BUG=crashpad:23

Committed: https://crrev.com/d922b3cacfcee6958d71de501a8ced7c25801965
Cr-Commit-Position: refs/heads/master@{#418063}
==========

[commit-bot: I haz the power, 2016-09-12 21:51:11]

Patchset 1 (id:??) landed as
https://crrev.com/d922b3cacfcee6958d71de501a8ced7c25801965
Cr-Commit-Position: refs/heads/master@{#418063}