Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: remoting/client/plugin/pepper_view.h

Issue 23677011: Byte-swap the video frame pixels before passing them to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove FrameConsumerProxy::Attach Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_view.h
diff --git a/remoting/client/plugin/pepper_view.h b/remoting/client/plugin/pepper_view.h
index 4027b620945fbcfd2196987b295298d28d3d671e..f8c3b023ebb82a037e4fd30383b6bb9d4e6cf59d 100644
--- a/remoting/client/plugin/pepper_view.h
+++ b/remoting/client/plugin/pepper_view.h
@@ -35,11 +35,9 @@ class FrameProducer;
class PepperView : public FrameConsumer {
public:
- // Constructs a PepperView for the |instance|. The |instance|, |context|
- // and |producer| must outlive this class.
- PepperView(ChromotingInstance* instance,
- ClientContext* context,
- FrameProducer* producer);
+ // Constructs a PepperView for the |instance|. The |instance| and |context|
+ // must outlive this class.
+ PepperView(ChromotingInstance* instance, ClientContext* context);
virtual ~PepperView();
// FrameConsumer implementation.
@@ -50,6 +48,7 @@ class PepperView : public FrameConsumer {
virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) OVERRIDE;
virtual void SetSourceSize(const webrtc::DesktopSize& source_size,
const webrtc::DesktopVector& dpi) OVERRIDE;
+ virtual PixelFormat GetPixelFormat() OVERRIDE;
// Updates the PepperView's size & clipping area, taking into account the
// DIP-to-device scale factor.
@@ -66,6 +65,10 @@ class PepperView : public FrameConsumer {
return dips_size_;
}
+ // Allocates buffers and passes them to the FrameProducer to render into until
+ // the maximum number of buffers are in-flight.
+ void InitiateDrawing(FrameProducer* producer);
Sergey Ulanov 2013/09/28 00:33:32 nit: Please rename it to Start() or Initialize().
Lambros 2013/09/28 00:51:11 Done.
+
private:
// Allocates a new frame buffer to supply to the FrameProducer to render into.
// Returns NULL if the maximum number of buffers has already been allocated.
@@ -74,10 +77,6 @@ class PepperView : public FrameConsumer {
// Frees a frame buffer previously allocated by AllocateBuffer.
void FreeBuffer(webrtc::DesktopFrame* buffer);
- // Allocates buffers and passes them to the FrameProducer to render into until
- // the maximum number of buffers are in-flight.
- void InitiateDrawing();
-
// Renders the parts of |buffer| identified by |region| to the view. If the
// clip area of the view has changed since the buffer was generated then
// FrameProducer is supplied the missed parts of |region|. The FrameProducer

Powered by Google App Engine
This is Rietveld 408576698