Byte-swap the video frame pixels before passing them to Java.

remoting/client/plugin/pepper_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class is an implementation of the ChromotingView for Pepper.  It is
 // callable only on the Pepper thread.
 
 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
 #define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
 
@@ skipping 17 matching lines @@
 }  // namespace webrtc
 
 namespace remoting {
 
 class ChromotingInstance;
 class ClientContext;
 class FrameProducer;
 
 class PepperView : public FrameConsumer {
  public:
-  // Constructs a PepperView for the |instance|. The |instance|, |context|
-  // and |producer| must outlive this class.
-  PepperView(ChromotingInstance* instance,
-             ClientContext* context,
-             FrameProducer* producer);
+  // Constructs a PepperView for the |instance|. The |instance| and |context|
+  // must outlive this class.
+  PepperView(ChromotingInstance* instance, ClientContext* context);
   virtual ~PepperView();
 
   // FrameConsumer implementation.
   virtual void ApplyBuffer(const webrtc::DesktopSize& view_size,
                            const webrtc::DesktopRect& clip_area,
                            webrtc::DesktopFrame* buffer,
                            const webrtc::DesktopRegion& region) OVERRIDE;
   virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) OVERRIDE;
   virtual void SetSourceSize(const webrtc::DesktopSize& source_size,
                              const webrtc::DesktopVector& dpi) OVERRIDE;
+  virtual PixelFormat GetPixelFormat() OVERRIDE;
 
   // Updates the PepperView's size & clipping area, taking into account the
   // DIP-to-device scale factor.
   void SetView(const pp::View& view);
 
   // Returns the dimensions of the most recently displayed frame, in pixels.
   const webrtc::DesktopSize& get_source_size() const {
     return source_size_;
   }
 
   // Return the dimensions of the view in Density Independent Pixels (DIPs).
   // Note that there may be multiple device pixels per DIP.
   const webrtc::DesktopSize& get_view_size_dips() const {
     return dips_size_;
   }
 
+  // Allocates buffers and passes them to the FrameProducer to render into until
+  // the maximum number of buffers are in-flight.
+  void InitiateDrawing(FrameProducer* producer);

[Sergey Ulanov, 2013/09/28 00:33:32]

nit: Please rename it to Start() or Initialize(). Also put it right after the
destructor, so it's clear that it should be called first.

[Lambros, 2013/09/28 00:51:11]

Done.

+
  private:
   // Allocates a new frame buffer to supply to the FrameProducer to render into.
   // Returns NULL if the maximum number of buffers has already been allocated.
   webrtc::DesktopFrame* AllocateBuffer();
 
   // Frees a frame buffer previously allocated by AllocateBuffer.
   void FreeBuffer(webrtc::DesktopFrame* buffer);
 
-  // Allocates buffers and passes them to the FrameProducer to render into until
-  // the maximum number of buffers are in-flight.
-  void InitiateDrawing();
-
   // Renders the parts of |buffer| identified by |region| to the view.  If the
   // clip area of the view has changed since the buffer was generated then
   // FrameProducer is supplied the missed parts of |region|.  The FrameProducer
   // will be supplied a new buffer when FlushBuffer() completes.
   void FlushBuffer(const webrtc::DesktopRect& clip_area,
                    webrtc::DesktopFrame* buffer,
                    const webrtc::DesktopRegion& region);
 
   // Handles completion of FlushBuffer(), triggering a new buffer to be
   // returned to FrameProducer for rendering.
@@ skipping 54 matching lines @@
   bool frame_received_;
 
   pp::CompletionCallbackFactory<PepperView> callback_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperView);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_