Updated to GVR 1.0 SDK

Updated to GVR 1.0 SDK

BUG=389343
Committed: https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba
Cr-Commit-Position: refs/heads/master@{#420686}

[bshe, 2016-09-23 14:37:29]

bshe@chromium.org changed reviewers:
+ bshe@chromium.org

[bshe, 2016-09-23 14:37:29]

lgtm

[bajones, 2016-09-23 16:39:52]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-23 16:39:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2367673002/#ps20001
(title: "A few final fixups")

[commit-bot: I haz the power, 2016-09-23 16:40:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2016-09-23 16:50:45]

The CQ bit was unchecked by bajones@chromium.org

[bajones, 2016-09-23 16:52:17]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-23 16:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2367673002/#ps40001
(title: "Prevent doubling up on neck modeling in VrShell")

[commit-bot: I haz the power, 2016-09-23 16:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:56:08]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bajones, 2016-09-23 17:09:41]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-23 17:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2367673002/#ps60001
(title: "Rebase to resolve conflicts")

[commit-bot: I haz the power, 2016-09-23 17:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 17:10:06]

This CL has an open dependency (Issue 2367673002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[bajones, 2016-09-23 17:23:24]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-23 17:23:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2367673002/#ps80001
(title: "Go away, spurious CL dependency")

[commit-bot: I haz the power, 2016-09-23 17:23:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[billorr, 2016-09-23 17:26:23]

billorr@chromium.org changed reviewers:
+ billorr@chromium.org

[billorr, 2016-09-23 17:26:24]

sending a review on a few nit issues, mostly to learn how our review tools work

https://codereview.chromium.org/2367673002/diff/40001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2367673002/diff/40001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:348: // Don't need to clear, since
we're drawing over the entire render target.
comment is now out of date

https://codereview.chromium.org/2367673002/diff/40001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2367673002/diff/40001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.cc:157: gfx::Transform inv_transform(
do we have a naming convention for transforms?  I like using aToB naming,
(headToView, neckToHead, etc.) to make transform issues more apparent.

are the matrices row-major or column major?

as a newcomer, I can't tell whether inv_transform is supposed to be an inverse
because we are taking the transpose of a rotation matrix, or we are just copying
the matrix, and the only inverse is below.

https://codereview.chromium.org/2367673002/diff/40001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_gamepad_data_fetcher.cc (right):

https://codereview.chromium.org/2367673002/diff/40001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_gamepad_data_fetcher.cc:98: // TODO: Query from API if
avaialable.
todo out of date?

https://codereview.chromium.org/2367673002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2367673002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:390: // Don't need to clear, since
we're drawing over the entire render target.
out of date comment

[commit-bot: I haz the power, 2016-09-23 19:08:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-23 19:09:57]

Description was changed from

==========
Updated to GVR 1.0 SDK

BUG=389343
==========

to

==========
Updated to GVR 1.0 SDK

BUG=389343

Committed: https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba
Cr-Commit-Position: refs/heads/master@{#420686}
==========

[commit-bot: I haz the power, 2016-09-23 19:09:58]

Patchset 5 (id:??) landed as
https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba
Cr-Commit-Position: refs/heads/master@{#420686}