src/objects-debug.cc - Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies (Closed)

Patch Set: Handled review comments, added a test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index ccb4b8d2a46899a8704ded3c34e13359299b613a..fee4ab36cce480e8d4bec0455ab318c488c7d08c 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -928,6 +928,7 @@ void Module::ModuleVerify() {

requested_modules()->ObjectVerify();

VerifySmiField(kFlagsOffset);

embedder_data()->ObjectVerify();

+ CHECK(shared()->name()->IsSymbol());

// TODO(neis): Check more.

}

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »