Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: src/objects-debug.cc

Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies (Closed)
Patch Set: Handled review comments, added a test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 } 921 }
922 922
923 void Module::ModuleVerify() { 923 void Module::ModuleVerify() {
924 CHECK(IsModule()); 924 CHECK(IsModule());
925 CHECK(code()->IsSharedFunctionInfo() || code()->IsJSFunction()); 925 CHECK(code()->IsSharedFunctionInfo() || code()->IsJSFunction());
926 code()->ObjectVerify(); 926 code()->ObjectVerify();
927 exports()->ObjectVerify(); 927 exports()->ObjectVerify();
928 requested_modules()->ObjectVerify(); 928 requested_modules()->ObjectVerify();
929 VerifySmiField(kFlagsOffset); 929 VerifySmiField(kFlagsOffset);
930 embedder_data()->ObjectVerify(); 930 embedder_data()->ObjectVerify();
931 CHECK(shared()->name()->IsSymbol());
931 // TODO(neis): Check more. 932 // TODO(neis): Check more.
932 } 933 }
933 934
934 void PrototypeInfo::PrototypeInfoVerify() { 935 void PrototypeInfo::PrototypeInfoVerify() {
935 CHECK(IsPrototypeInfo()); 936 CHECK(IsPrototypeInfo());
936 if (prototype_users()->IsWeakFixedArray()) { 937 if (prototype_users()->IsWeakFixedArray()) {
937 WeakFixedArray::cast(prototype_users())->FixedArrayVerify(); 938 WeakFixedArray::cast(prototype_users())->FixedArrayVerify();
938 } else { 939 } else {
939 CHECK(prototype_users()->IsSmi()); 940 CHECK(prototype_users()->IsSmi());
940 } 941 }
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 1363
1363 // Both are done at the same time. 1364 // Both are done at the same time.
1364 CHECK_EQ(new_it.done(), old_it.done()); 1365 CHECK_EQ(new_it.done(), old_it.done());
1365 } 1366 }
1366 1367
1367 1368
1368 #endif // DEBUG 1369 #endif // DEBUG
1369 1370
1370 } // namespace internal 1371 } // namespace internal
1371 } // namespace v8 1372 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698