src/messages.h - Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.h

Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies (Closed)

Patch Set: Handled review comments, added a test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.h

diff --git a/src/messages.h b/src/messages.h

index f92bbafdd779b60a6e517f93815faacbc72f89ef..002d2a637a33a322dd0c51e37eb9df4c10cb93fa 100644

--- a/src/messages.h

+++ b/src/messages.h

@@ -254,6 +254,7 @@ class ErrorUtils : public AllStatic {

T(ConstructorNotFunction, "Constructor % requires 'new'") \

T(ConstructorNotReceiver, "The .constructor property is not an object") \

T(CurrencyCode, "Currency code is required with currency style.") \

+ T(CyclicModuleDependency, "Detected cycle while resolving name '%'") \

T(DataViewNotArrayBuffer, \

"First argument to DataView constructor must be an ArrayBuffer") \

T(DateType, "this is not a Date object.") \

« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | no next file with comments »