Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/messages.h

Issue 2367623004: [modules] Detect and throw exceptions for cyclic dependencies (Closed)
Patch Set: Handled review comments, added a test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The infrastructure used for (localized) message reporting in V8. 5 // The infrastructure used for (localized) message reporting in V8.
6 // 6 //
7 // Note: there's a big unresolved issue about ownership of the data 7 // Note: there's a big unresolved issue about ownership of the data
8 // structures used by this framework. 8 // structures used by this framework.
9 9
10 #ifndef V8_MESSAGES_H_ 10 #ifndef V8_MESSAGES_H_
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 T(CannotFreezeArrayBufferView, \ 247 T(CannotFreezeArrayBufferView, \
248 "Cannot freeze array buffer views with elements") \ 248 "Cannot freeze array buffer views with elements") \
249 T(CircularStructure, "Converting circular structure to JSON") \ 249 T(CircularStructure, "Converting circular structure to JSON") \
250 T(ConstructAbstractClass, "Abstract class % not directly constructable") \ 250 T(ConstructAbstractClass, "Abstract class % not directly constructable") \
251 T(ConstAssign, "Assignment to constant variable.") \ 251 T(ConstAssign, "Assignment to constant variable.") \
252 T(ConstructorNonCallable, \ 252 T(ConstructorNonCallable, \
253 "Class constructor % cannot be invoked without 'new'") \ 253 "Class constructor % cannot be invoked without 'new'") \
254 T(ConstructorNotFunction, "Constructor % requires 'new'") \ 254 T(ConstructorNotFunction, "Constructor % requires 'new'") \
255 T(ConstructorNotReceiver, "The .constructor property is not an object") \ 255 T(ConstructorNotReceiver, "The .constructor property is not an object") \
256 T(CurrencyCode, "Currency code is required with currency style.") \ 256 T(CurrencyCode, "Currency code is required with currency style.") \
257 T(CyclicModuleDependency, "Detected cycle while resolving name '%'") \
257 T(DataViewNotArrayBuffer, \ 258 T(DataViewNotArrayBuffer, \
258 "First argument to DataView constructor must be an ArrayBuffer") \ 259 "First argument to DataView constructor must be an ArrayBuffer") \
259 T(DateType, "this is not a Date object.") \ 260 T(DateType, "this is not a Date object.") \
260 T(DebuggerFrame, "Debugger: Invalid frame index.") \ 261 T(DebuggerFrame, "Debugger: Invalid frame index.") \
261 T(DebuggerType, "Debugger: Parameters have wrong types.") \ 262 T(DebuggerType, "Debugger: Parameters have wrong types.") \
262 T(DeclarationMissingInitializer, "Missing initializer in % declaration") \ 263 T(DeclarationMissingInitializer, "Missing initializer in % declaration") \
263 T(DefineDisallowed, "Cannot define property:%, object is not extensible.") \ 264 T(DefineDisallowed, "Cannot define property:%, object is not extensible.") \
264 T(DetachedOperation, "Cannot perform % on a detached ArrayBuffer") \ 265 T(DetachedOperation, "Cannot perform % on a detached ArrayBuffer") \
265 T(DuplicateTemplateProperty, "Object template has duplicate property '%'") \ 266 T(DuplicateTemplateProperty, "Object template has duplicate property '%'") \
266 T(ExtendsValueNotConstructor, \ 267 T(ExtendsValueNotConstructor, \
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data); 690 static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
690 static std::unique_ptr<char[]> GetLocalizedMessage(Isolate* isolate, 691 static std::unique_ptr<char[]> GetLocalizedMessage(Isolate* isolate,
691 Handle<Object> data); 692 Handle<Object> data);
692 }; 693 };
693 694
694 695
695 } // namespace internal 696 } // namespace internal
696 } // namespace v8 697 } // namespace v8
697 698
698 #endif // V8_MESSAGES_H_ 699 #endif // V8_MESSAGES_H_
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698