[modules] Detect and throw exceptions for cyclic dependencies

src/objects.h

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index ca3c8f89b7c5bbac73d62cd5e3c597b1f41c258b..846e9019a7a1e8649b08c89f120aa97276c515dc 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7948,9 +7948,15 @@ class Module : public Struct {
   // Embedder-specified data
   DECL_ACCESSORS(embedder_data, Object)
 
+  // Returns the SharedFunctionInfo associated with the code.
+  inline SharedFunctionInfo* shared() const;
+

[neis, 2016/09/26 21:06:28]

s/Returns/Get/ for consistency

[adamk, 2016/09/26 21:20:46]

Done.

   // Get the ModuleInfo associated with the code.
   inline ModuleInfo* info() const;
 
+  // Compute a hash code for this object.
+  inline uint32_t Hash() const;

[neis, 2016/09/26 21:06:28]

s/code //

[adamk, 2016/09/26 21:20:46]

Done.

+
   static void CreateExport(Handle<Module> module, Handle<FixedArray> names);
   static Handle<Object> LoadExport(Handle<Module> module, Handle<String> name);
   static void StoreExport(Handle<Module> module, Handle<String> name,
@@ -7962,11 +7968,13 @@ class Module : public Struct {
   static Handle<Object> LoadImport(Handle<Module> module, Handle<String> name,
                                    int module_request);
 
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(Handle<Module> module,
-                                                         Handle<String> name,
-                                                         int module_request);
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(Handle<Module> module,
-                                                         Handle<String> name);
+  class ResolveSet;
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(
+      Handle<Module> module, Handle<String> name, int module_request,
+      ResolveSet* resolve_set, Zone* zone);
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(
+      Handle<Module> module, Handle<String> name, ResolveSet* resolve_set,
+      Zone* zone);
 
   static const int kCodeOffset = HeapObject::kHeaderSize;
   static const int kExportsOffset = kCodeOffset + kPointerSize;
@@ -7978,6 +7986,12 @@ class Module : public Struct {
  private:
   enum { kEvaluatedBit };
 
+  class UnorderedStringSet;
+  struct ModuleHandleEqual;
+  struct StringHandleEqual;
+  template <typename T>
+  struct HandleValueHash;
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(Module);
 };