[modules] Detect and throw exceptions for cyclic dependencies

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 7930 matching lines @@
   // [[Evaluated]]: Whether this module has been evaluated. Modules
   // are only evaluated a single time.
   DECL_BOOLEAN_ACCESSORS(evaluated)
 
   // Storage for [[Evaluated]]
   DECL_INT_ACCESSORS(flags)
 
   // Embedder-specified data
   DECL_ACCESSORS(embedder_data, Object)
 
+  // Returns the SharedFunctionInfo associated with the code.
+  inline SharedFunctionInfo* shared() const;
+

[neis, 2016/09/26 21:06:28]

s/Returns/Get/ for consistency

[adamk, 2016/09/26 21:20:46]

Done.

   // Get the ModuleInfo associated with the code.
   inline ModuleInfo* info() const;
 
+  // Compute a hash code for this object.
+  inline uint32_t Hash() const;

[neis, 2016/09/26 21:06:28]

s/code //

[adamk, 2016/09/26 21:20:46]

Done.

+
   static void CreateExport(Handle<Module> module, Handle<FixedArray> names);
   static Handle<Object> LoadExport(Handle<Module> module, Handle<String> name);
   static void StoreExport(Handle<Module> module, Handle<String> name,
                           Handle<Object> value);
 
   static void CreateIndirectExport(Handle<Module> module, Handle<String> name,
                                    Handle<ModuleInfoEntry> entry);
 
   static Handle<Object> LoadImport(Handle<Module> module, Handle<String> name,
                                    int module_request);
 
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(Handle<Module> module,
-                                                         Handle<String> name,
-                                                         int module_request);
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(Handle<Module> module,
-                                                         Handle<String> name);
+  class ResolveSet;
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(
+      Handle<Module> module, Handle<String> name, int module_request,
+      ResolveSet* resolve_set, Zone* zone);
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(
+      Handle<Module> module, Handle<String> name, ResolveSet* resolve_set,
+      Zone* zone);
 
   static const int kCodeOffset = HeapObject::kHeaderSize;
   static const int kExportsOffset = kCodeOffset + kPointerSize;
   static const int kRequestedModulesOffset = kExportsOffset + kPointerSize;
   static const int kFlagsOffset = kRequestedModulesOffset + kPointerSize;
   static const int kEmbedderDataOffset = kFlagsOffset + kPointerSize;
   static const int kSize = kEmbedderDataOffset + kPointerSize;
 
  private:
   enum { kEvaluatedBit };
 
+  class UnorderedStringSet;
+  struct ModuleHandleEqual;
+  struct StringHandleEqual;
+  template <typename T>
+  struct HandleValueHash;
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(Module);
 };
 
 // JSBoundFunction describes a bound function exotic object.
 class JSBoundFunction : public JSObject {
  public:
   // [bound_target_function]: The wrapped function object.
   DECL_ACCESSORS(bound_target_function, JSReceiver)
 
   // [bound_this]: The value that is always passed as the this value when
@@ skipping 3426 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_