[HBD] Merge two identical ShouldUseJavaScriptSettingForPlugin impls

chrome/common/plugin_utils.h

Index: chrome/common/plugin_utils.h
diff --git a/chrome/common/plugin_utils.h b/chrome/common/plugin_utils.h
new file mode 100644
index 0000000000000000000000000000000000000000..0dd8d7f8a548a9f691e7c94aacc39565a485e8be
--- /dev/null
+++ b/chrome/common/plugin_utils.h
@@ -0,0 +1,15 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_PLUGIN_UTILS_H_
+#define CHROME_COMMON_PLUGIN_UTILS_H_
+
+namespace content {
+struct WebPluginInfo;
+}
+
+// Only Flash should use the Plugin content setting.

[Lei Zhang, 2016/09/23 05:00:52]

This mentions Flash, but the impl doesn't check for Flash?

[xhwang, 2016/09/23 16:42:17]

+1

And JavaScriptSettingForPlugin isn't always self explanatory for a lot of
people.

[tommycli, 2016/09/23 16:46:45]

Done.

Updated the comment. Sorry, this leaked into this patch from the followup patch

+bool ShouldUseJavaScriptSettingForPlugin(const content::WebPluginInfo& plugin);
+
+#endif  // CHROME_COMMON_PLUGIN_UTILS_H_