chrome/common/plugin_utils.h - Issue 2367553002: [HBD] Merge two identical ShouldUseJavaScriptSettingForPlugin impls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/plugin_utils.h

Issue 2367553002: [HBD] Merge two identical ShouldUseJavaScriptSettingForPlugin impls (Closed)

Patch Set: merge origin/master Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_PLUGIN_UTILS_H_

	6 #define CHROME_COMMON_PLUGIN_UTILS_H_

	7

	8 namespace content {

	9 struct WebPluginInfo;

	10 }

	11

	12 // Only Flash should use the Plugin content setting.
	Lei Zhang 2016/09/23 05:00:52 This mentions Flash, but the impl doesn't check fo This mentions Flash, but the impl doesn't check for Flash? xhwang 2016/09/23 16:42:17 +1 And JavaScriptSettingForPlugin isn't always se Show quoted text On 2016/09/23 05:00:52, Lei Zhang wrote: > This mentions Flash, but the impl doesn't check for Flash? +1 And JavaScriptSettingForPlugin isn't always self explanatory for a lot of people. tommycli 2016/09/23 16:46:45 Done. Updated the comment. Sorry, this leaked int Show quoted text On 2016/09/23 16:42:17, xhwang (slow) wrote: > On 2016/09/23 05:00:52, Lei Zhang wrote: > > This mentions Flash, but the impl doesn't check for Flash? > > +1 > > And JavaScriptSettingForPlugin isn't always self explanatory for a lot of > people. Done. Updated the comment. Sorry, this leaked into this patch from the followup patch
	13 bool ShouldUseJavaScriptSettingForPlugin(const content::WebPluginInfo& plugin);

	14

	15 #endif // CHROME_COMMON_PLUGIN_UTILS_H_

OLD	NEW